Skip to content

feat(review): make fast mode best effort#525

Merged
rianjs merged 5 commits into
mainfrom
feat/524-best-effort-fast-mode
Jul 21, 2026
Merged

feat(review): make fast mode best effort#525
rianjs merged 5 commits into
mainfrom
feat/524-best-effort-fast-mode

Conversation

@rianjs

@rianjs rianjs commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • add profile and CLI fast-mode precedence
  • warn and fall back for unsupported reviewer runtimes/models
  • support Codex CLI fast service tier and record ignored requests

Tests:

  • make check

Closes #524

@rianjs

rianjs commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

No findings. The PR now matches the ticket’s requested/effective fast-mode semantics, preserves full-catalog preflight validation, keeps fallback artifacts truthful, and stays narrowly scoped. Focused verification passed: 599 tests across the five affected packages.

@rianjs

rianjs commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author
  • [Major] Missing end-to-end unsupported-runtime fallback coverage. The only runtime-level test uses an empty catalog, while the integration test covers an unsupported model. Add a real pipeline test proving an unsupported runtime warns, completes successfully, sends all requests with Fast=false, and records fast_ignored=true.

  • [Major] Preflight ordering is not proven. TestResolveReviewerFastModeDoesNotHideLaterModelErrors calls the resolver directly, so it would pass even if production invoked it after selection/LLM work. Add an integration test with a later invalid reviewer and assert the adapter receives zero requests, preserving all-reviewer preflight semantics.

  • [Minor] Supported artifact truthfulness lacks coverage. The patch verifies only the ignored fallback case. Add one supported-fast case asserting fast_ignored=false and fast_delivered reflects provider-reported fast or standard.

@rianjs-bot rianjs-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: 02a93c3c1c17
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]

Summary

Reviewer Findings
go:implementation-tests 0
documentation:docs 0
policies:conventions 0
structure:repo-health 0

Reviewer Coverage

Reviewer Status Inspected Skipped Constraints
go:implementation-tests complete_broad internal/app/runtime_test.go, internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/config/config.go, internal/config/config_test.go, internal/llmadapters/subprocess.go, internal/llmadapters/subprocess_test.go, internal/pipeline/artifacts.go, internal/pipeline/pipeline.go, internal/pipeline/pipeline_test.go, internal/pipeline/prompts.go unavailable Focused on Go implementation quality and behavioral test coverage in the assigned diff. Targeted go test invocation could not build in this workspace because clang received the path containing spaces as split arguments.
documentation:docs complete_broad README.md, docs/init-config-surface.md unavailable Documentation-only review scoped to the assigned changed files; verified fast-mode claims against the related config, command, adapter, and pipeline code.
policies:conventions complete_broad README.md, docs/init-config-surface.md, internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/config/config.go, internal/config/config_test.go, internal/pipeline/artifacts.go, internal/pipeline/pipeline.go, internal/pipeline/pipeline_test.go, internal/pipeline/prompts.go unavailable Shared cli-common and .github convenience copies were not present; review used repo-local guidance and changed files only.
structure:repo-health complete_broad internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/config/config.go, internal/config/config_test.go, internal/pipeline/artifacts.go, internal/pipeline/pipeline.go, internal/pipeline/pipeline_test.go, internal/pipeline/prompts.go unavailable Native CGO test execution was blocked by the sandbox path containing spaces; the assigned-package tests passed with CGO disabled.; Review scoped to the assigned files and structural risks.

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 2m 38s | unavailable | gpt-5.6-terra | cr 0.10.265
Field Value
Model gpt-5.6-terra
Reviewers go:implementation-tests, documentation:docs, policies:conventions, structure:repo-health
Engine codex_cli · gpt-5.6-terra
Reviewed by cr · rianjs-bot[bot]
Duration 2m 38s wall · 5m 45s compute
Cost unavailable
Tokens 1.6M in / 13.4k out

Per-workstream usage

Workstream Model In Out Cache read Cache create Cost Duration
orchestrator-selection gpt-5.6-terra 15.5k 484 10.5k unavailable unavailable 11s
go:implementation-tests gpt-5.6-terra 621.4k 3.9k 538.4k unavailable unavailable 1m 40s
documentation:docs gpt-5.6-terra 266.0k 2.6k 185.6k unavailable unavailable 1m 00s
policies:conventions gpt-5.6-terra 217.4k 2.3k 164.9k unavailable unavailable 51s
structure:repo-health gpt-5.6-terra 491.0k 3.6k 434.2k unavailable unavailable 1m 56s
orchestrator-rollup gpt-5.6-terra 33.3k 521 25.6k unavailable unavailable 4s

@rianjs

rianjs commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Final architect pass: 0 blockers, 0 majors, 0 minors. One nit identified a redundant private-helper test; removed in c130f46 while retaining the stronger end-to-end preflight coverage. Focused fast-mode pipeline tests pass.

@rianjs
rianjs merged commit 6873d07 into main Jul 21, 2026
10 checks passed
@rianjs
rianjs deleted the feat/524-best-effort-fast-mode branch July 21, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make fast mode best-effort, configurable per profile, and support Codex CLI

1 participant