Remove validated ORT core patches - #882
Open
tzuhsuanwei wants to merge 1 commit into
Open
tzuhsuanwei wants to merge 1 commit into
tzuhsuanwei wants to merge 1 commit into
Conversation
tzuhsuanwei
requested review from
minfhong-qti,
qti-ashwshan,
qti-chuteng,
qti-kromero,
qti-shubham,
qti-yuduo,
tirupath-qti and
yuhuchua-qti
as code owners
September 29, 2026 08:34
tzuhsuanwei
force-pushed
the
dev/tzuhwei/remove-ort-core-patches-0002-0005
branch
4 times, most recently
from
September 29, 2026 08:46
25c82fa to
e8e89ae
Compare
qti-yuduo
force-pushed
the
dev/tzuhwei/remove-ort-core-patches-0002-0005
branch
from
September 29, 2026 16:20
e8e89ae to
5de73e0
Compare
qti-yuduo
approved these changes
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes ORT-core patches 0002, 0004, and 0005 so the QNN plugin can build against a cleaner, unmodified upstream ORT source tree.
Patch 0002 previously changed ORT core solely to prevent the model runner from executing three QNN HTP RoiAlign test directories. The upstream plugin runner accepts a suite directory but has no per-case skip argument. Removing 0002 without replacement would make the normal full node-suite workflow execute est_roialign_mode_max, which is currently unsupported on QNN HTP and returns Not implemented.
Therefore this PR moves that test-selection policy out of ORT core and into a QNN-owned Python filter. Windows and Linux launchers call the filter before invoking the upstream plugin runner; Appium/QDC applies it before uploading the node suite to the device. The runner receives a temporary filtered suite, so ORT itself remains pristine and no longer needs a QNN-specific skip patch. This preserves the prior test workflow while keeping the ORT patch chain clean.
Final patch disposition
Validation