Skip to content

Add onnxruntime/capi to MIGraphX wheel runpath - #114

Merged
TedThemistokleous merged 1 commit into
mainfrom
fix/onnxrt-capi-missing
Sep 10, 2026
Merged

TedThemistokleous merged 1 commit into
mainfrom
fix/onnxrt-capi-missing

Conversation

@kentqian

Copy link
Copy Markdown
Collaborator

Summary

Add the sibling onnxruntime/capi directory to the packaged MIGraphX EP library RUNPATH.

libmigraphx-ep.so depends on the ONNX Runtime shared library, which is installed under site-packages/onnxruntime/capi. Without this path, plugin registration can fail in an isolated Python environment even when the onnxruntime dependency is installed.

@kentqian kentqian self-assigned this Sep 10, 2026
Copilot AI lite review requested due to automatic review settings September 10, 2026 17:11
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, targeted RUNPATH update in the wheel-staging patch step that aligns with the documented site-packages layout and does not alter build logic beyond adding one additional lookup directory.

Pull request overview

This PR updates the MIGraphX EP wheel packaging logic to include the onnxruntime/capi sibling directory in the ELF RUNPATH for the staged MIGraphX EP shared library, ensuring it can locate the ONNX Runtime shared library from an installed onnxruntime Python package in isolated environments.

Changes:

  • Add $ORIGIN/../onnxruntime/capi to the computed RUNPATH used when patching libmigraphx-ep.so (and related MIGraphX artifacts) during wheel staging.
File summaries
File Description
tools/ci_build/build.py Extends the Linux wheel RUNPATH patching for MIGraphX EP libraries to search the installed onnxruntime/capi directory.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@TedThemistokleous
TedThemistokleous enabled auto-merge (squash) September 10, 2026 17:43
@TedThemistokleous
TedThemistokleous merged commit db10ad4 into main Sep 10, 2026
1 of 2 checks passed
@TedThemistokleous
TedThemistokleous deleted the fix/onnxrt-capi-missing branch September 10, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants