Add onnxruntime/capi to MIGraphX wheel runpath - #114
Conversation
|
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, targeted RUNPATH update in the wheel-staging patch step that aligns with the documented site-packages layout and does not alter build logic beyond adding one additional lookup directory.
Pull request overview
This PR updates the MIGraphX EP wheel packaging logic to include the onnxruntime/capi sibling directory in the ELF RUNPATH for the staged MIGraphX EP shared library, ensuring it can locate the ONNX Runtime shared library from an installed onnxruntime Python package in isolated environments.
Changes:
- Add
$ORIGIN/../onnxruntime/capito the computed RUNPATH used when patchinglibmigraphx-ep.so(and related MIGraphX artifacts) during wheel staging.
File summaries
| File | Description |
|---|---|
| tools/ci_build/build.py | Extends the Linux wheel RUNPATH patching for MIGraphX EP libraries to search the installed onnxruntime/capi directory. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
Add the sibling
onnxruntime/capidirectory to the packaged MIGraphX EP library RUNPATH.libmigraphx-ep.sodepends on the ONNX Runtime shared library, which is installed undersite-packages/onnxruntime/capi. Without this path, plugin registration can fail in an isolated Python environment even when theonnxruntimedependency is installed.