Fix GridSample always using nearest mode on opset 20+ - #1060
Open
mertalev wants to merge 1 commit into
Open
Conversation
mertalev
force-pushed
the
fix/gridsample-mode-naming
branch
from
July 11, 2026 02:00
6fb9f33 to
4538c13
Compare
Signed-off-by: Mert Alev <101130780+mertalev@users.noreply.github.com>
mertalev
force-pushed
the
fix/gridsample-mode-naming
branch
from
July 11, 2026 02:02
4538c13 to
a405536
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GridSample 20 renamed bilinear and bicubic to linear and cubic, respectively. This meant the checks for
bilinearandbicubicdon't match and it silently falls back tonearest. Reproduced with both TensorRT 11.1 and TensorRT-RTX 1.5.This PR makes it accept both strings and aborts when it encounters an unknown string instead of using the wrong mode.
Fixes NVIDIA/TensorRT#4646