change default source directory to /src/Document - #958
Open
mjvanmiddelaar wants to merge 1 commit into
Open
Conversation
This was referenced Jul 27, 2020
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONGR\ElasticsearchBundle\DependencyInjection\Compiler\MappingPassautoloads literally all classes in the default source directory, which is/srcIt cannot be assumed all classes in
/srcabide by the PSR-0 standard or have autoloading setup in a different way. For instance, Doctrine Migrations after default SF5 setup, will be placed in/src/Migrationsand they cannot be autoloaded by default.Since the README.md suggests to place new Document classes in
/src/Document, it is my proposal to make/src/Documentthe default source directory for the ElasticsearchBundle so developers can install this bundle on new Symfony 5 application without running into autoloading issues.