[CompactSealedState] T1: add SearchRootHashBackward to common WAL utilities - #8670
Draft
zhangchiqing wants to merge 1 commit into
Draft
[CompactSealedState] T1: add SearchRootHashBackward to common WAL utilities#8670zhangchiqing wants to merge 1 commit into
zhangchiqing wants to merge 1 commit into
Conversation
Extracts WAL root-hash search logic from find-trie-root into cmd/util/cmd/common/wal.go as exported SearchRootHashForward and SearchRootHashBackward functions. The backward variant iterates segments last-to-first (per-segment records still read forward), which is efficient when the target hash is near the end of the WAL. Updates find-trie-root to use SearchRootHashBackward via the shared package. Adds unit tests covering single-segment, multi-segment, last-occurrence, bounded-range, and not-found cases. Part of #8665.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8665.
Extracts WAL root-hash search logic from find-trie-root into cmd/util/cmd/common/wal.go as exported SearchRootHashForward and SearchRootHashBackward functions. The backward variant iterates segments last-to-first (per-segment records still read forward), which is efficient when the target hash is near the end of the WAL.
Updates find-trie-root to use SearchRootHashBackward via the shared package. Adds unit tests covering single-segment, multi-segment, last-occurrence, bounded-range, and not-found cases.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.