Skip to content

[Storehouse] 008 Replay WAL onto Payloadless trie - #8598

Open
zhangchiqing wants to merge 7 commits into
leo/payloadless-checkpoint-v7from
leo/payloadless-wal-files
Open

[Storehouse] 008 Replay WAL onto Payloadless trie#8598
zhangchiqing wants to merge 7 commits into
leo/payloadless-checkpoint-v7from
leo/payloadless-wal-files

Conversation

@zhangchiqing

@zhangchiqing zhangchiqing commented Jul 2, 2026

Copy link
Copy Markdown
Member

The previous PR #8578 defines a checkpoint, and can start up the node with a v7 checkpoint.

This PR adds the white ahead logs (WAL) replaying for payloadless trie so that on startup, after loading a payloadless checkpoint file, it can continue replaying the WAL files deriving the trie for the last executed block and resume the execution.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ccb6354-bb98-415e-a305-242020b1fcc7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch leo/payloadless-wal-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zhangchiqing
zhangchiqing marked this pull request as ready for review July 6, 2026 15:39
@zhangchiqing
zhangchiqing requested a review from a team as a code owner July 6, 2026 15:39
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from ba2d7d5 to d7bd6df Compare July 13, 2026 17:25
@zhangchiqing zhangchiqing changed the title [Storehouse] 008 Payloadless WAL [Storehouse] 008 Replay WAL onto Payloadless trie Jul 13, 2026
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from d7bd6df to 96c606b Compare July 14, 2026 18:19
// calling this.
//
// No error returns are expected during normal operation.
func (w *DiskWAL) replaySegments(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-existing, but the read loop below checks reader.Err() only inside the loop. reader.Next() returns false on both clean EOF and read error, so if the final Next() returns false due to a corrupt/truncated record, reader.Err() is non-nil but never checked.

@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from 96c606b to 5a0946c Compare July 31, 2026 03:20
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from 85e253e to 9efab91 Compare August 18, 2026 01:55
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter

codecov-commenter commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from 9efab91 to 4e07b5c Compare August 18, 2026 15:43
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from 4e07b5c to e8549af Compare August 18, 2026 17:25
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from e8549af to 5266d70 Compare August 18, 2026 18:17
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from 5266d70 to ade7a77 Compare August 18, 2026 20:29
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from ade7a77 to 32df6b5 Compare August 24, 2026 14:01
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from 32df6b5 to fa4dd3e Compare August 25, 2026 02:47
@blacksmith-sh

This comment has been minimized.

@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-wal-files branch from fa4dd3e to b12753d Compare August 25, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants