Skip to content

[Storehouse] 005 Payloadless View Committer - #8576

Open
zhangchiqing wants to merge 7 commits into
leo/payloadless-ledgerfrom
leo/payloadless-view-committer
Open

[Storehouse] 005 Payloadless View Committer#8576
zhangchiqing wants to merge 7 commits into
leo/payloadless-ledgerfrom
leo/payloadless-view-committer

Conversation

@zhangchiqing

@zhangchiqing zhangchiqing commented Jun 8, 2026

Copy link
Copy Markdown
Member
  • Add Payloadless View Committer. It's different from the original View committer as it creates proof by retrieving the payloadless proof from payloadless trie, and retrieve payload value from storehouse, and then verify the leaf hash and reconstruct the proof.
    See Spec

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8791cfeb-3f85-4d0b-a22b-a120ae313eca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch leo/payloadless-view-committer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

return baseStorageSnapshot.Get(id)
}

proof, err = payloadless.ProveAndReconstruct(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valueReader is the storehouse. Reconstructing the proof happens in the ProveAndReconstruct functions, it also verifies the payload value retrieved from valueReader matches the leafHash from the payloadless trie.

@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from 433a42e to 5d35e82 Compare June 8, 2026 23:31
@zhangchiqing
zhangchiqing marked this pull request as ready for review June 8, 2026 23:34
@zhangchiqing
zhangchiqing requested a review from a team as a code owner June 8, 2026 23:34
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from 5d35e82 to d4f7065 Compare June 18, 2026 23:16
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from d4f7065 to a66eeaa Compare June 19, 2026 00:00
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from a66eeaa to 553a243 Compare July 2, 2026 18:01
Base automatically changed from leo/payloadless-remote-service to leo/payloadless-ledger July 13, 2026 15:12
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from 553a243 to c526d24 Compare July 13, 2026 17:24
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from d0ee257 to 117e558 Compare August 18, 2026 01:55
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter

codecov-commenter commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ion/computation/committer/payloadless_committer.go 95.65% 1 Missing and 1 partial ⚠️
engine/execution/state/state.go 33.33% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch 3 times, most recently from b6d11a5 to 8b672e4 Compare August 18, 2026 16:54
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from b230c3f to 242b30e Compare August 18, 2026 18:17
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from 242b30e to c5dce46 Compare August 18, 2026 20:28
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from c5dce46 to 8049d1f Compare August 24, 2026 14:00
@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from 8049d1f to 67195f3 Compare August 25, 2026 02:47
@blacksmith-sh

This comment has been minimized.

@zhangchiqing
zhangchiqing force-pushed the leo/payloadless-view-committer branch from 67195f3 to 2a29ca6 Compare August 25, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants