Repository navigation
Conversation
Move pairing and control TLS I/O onto shared bounded carrier credits and a serialized memory-BIO pump. Add a private bidirectional Python/Go streaming peer to exercise fragmentation, coalescing, backpressure, partial writes, and actual-worker ownership during cancellation. Validation: 1,665 unit tests passed (43 skipped), 61 real native-peer tests passed, Go test/vet passed, Black checked 143 files, and pyrefly reported zero errors. The optional full Python suite retains one Docker-access failure.
CI failed: Five unit tests in the server suite timed out waiting on bounded HTTP capacity and request completion (artifact lock contention, cancelled request, and request-body admission cases), while the other 1,660 tests passed. The analyzer judged these unrelated to this PR, though the stall cause is not confirmed.OverviewOne unique failure pattern was found across 2 logs (one job, 126428454138). The Python 3.10 compat nox session ran 1,666 tests: 1,660 passed, 43 skipped, and 5 failed with FailuresFive asyncio timeouts in bounded capacity/request tests (confidence: medium)
Summary
Code Review ✅ Approved🟡 Medium risk · Refactoring pairing/control TLS I/O into a shared streaming pump changes transport and buffer-credit handling; errors could disrupt exchanges or exceed buffer limits. Moves pairing and control TLS I/O onto shared bounded carrier credits and a serialized memory-BIO pump, and adds a private bidirectional Python/Go streaming peer to exercise fragmentation, coalescing, backpressure, partial writes, and worker ownership during cancellation. No issues found. VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Move pairing and control TLS I/O onto shared bounded carrier credits and a serialized memory-BIO pump. Add a private bidirectional Python/Go streaming peer to exercise fragmentation, coalescing, backpressure, partial writes, and actual-worker ownership during cancellation.
Validation: 1,665 unit tests passed (43 skipped), 61 real native-peer tests passed, Go test/vet passed, Black checked 143 files, and pyrefly reported zero errors. The optional full Python suite retains one Docker-access failure.