Skip to content

Restructure RFC documents to use a YAML front matter for Status and author/reviewer/commenter metadata - #552

Merged
joshmoore merged 43 commits into
ome:mainfrom
lubianat:rfc_yaml_header
Oct 23, 2026
Merged

joshmoore merged 43 commits into
ome:mainfrom
lubianat:rfc_yaml_header

Conversation

@lubianat

@lubianat lubianat commented Jul 1, 2026 •

Copy link
Copy Markdown
Contributor

First step towards a system with more automation/standardization for rfc status management.

German-BioImaging/ome-zarr-ideas#54

  • feat: build authors from yaml header
  • test setup for rfc 9 comment 5
grafik

Next steps:

  • Change the metadata for other reviews / comments
  • Build the summary on the RFC main page from the index
  • Build the overall index from the metadata on each page using a decision tree (has comment -> y, etc etc)
  • Validate the front matter in target documents with a LinkML schema

EDIT: Ready to review!

To review:

  • Compare the generated RFC pages with the older one.

  • Provide feedback on the new look and feel and if changes are needed

  • Compare the page listing the different RFCs with the older one

  • If checking all 57 documents is too much, pick a sample and see if it is okay

  • If you are a schema person, look at rfc/schema/front_matter.yaml for the LinkML schema

  • If you are a sphinx person, look at _ext and document_authors.py and rfc_status.py and see if the directives make sense

Note that a lot of the code and changes have been aided by a Claude Opus 5 agent, though I tried to steer for minimal changes and maximize readability.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Automated Review URLs

@jo-mueller

jo-mueller commented Jul 2, 2026 •

Copy link
Copy Markdown
Contributor

Might benefit from a template, i.e. for RFCs and comments?

@jo-mueller

Copy link
Copy Markdown
Contributor

Also; it may be worth to drop the affiliations from the rendered text, similar to how it's done at ngff-spec. The reasoning there was, that a person's orcid is likely informative enough about past and present affiliations.

Comment thread rfc/9/comments/5/index.md Resolved
Comment thread rfc/9/comments/5/index.md Resolved
@lubianat

lubianat commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

a person's orcid is likely informative enough about past and present affiliations.

in theory, yes, it should. in practice, I need to keep the information provided by the authors on under which affiliation that comment was made.

an example is the rfc 9 / comment 5

Anna Kreshuk - ilastik was the intended affiliation, though that is a project and not an employee, and not listed on https://orcid.org/0000-0003-1334-6388

@lubianat lubianat added documentation Improvements or additions to documentation infra Concern: basic infrastructure labels Aug 21, 2026
@lubianat lubianat mentioned this pull request Sep 7, 2026

@gouttegd gouttegd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting for now. I have mostly looked at the LinkML stuff, not the Python code in details.

Comment thread rfc/0/index.md Resolved
Comment thread _ext/document_authors.py Resolved
Comment thread _ext/rfc_status.py Resolved
Comment thread rfc/schema/front_matter.yaml Resolved
Comment thread rfc/schema/front_matter.yaml Resolved
Comment thread rfc/schema/validate.py Resolved
@lubianat

Copy link
Copy Markdown
Contributor Author

Just commenting for now. I have mostly looked at the LinkML stuff, not the Python code in details.

That is excellent, thank you. I'll actually refactor some of it as you suggested.

As I mentioned in the PR description, there is a lot that was generated with Claude assist. Reviewed, but still, it is a big change, so I am not sure how to make the review process less painful.

@jo-mueller

Copy link
Copy Markdown
Contributor

Something that bumps me mildly is that the author information is rendered differently for the RFC document itself (the old table) and the reviews/comments/etc, where the frontmatter yaml is used.

I think jupyter-book or myst-md are also able to do this based on frontmatter yaml that looks very similar to what we have here. If you check the auto-built metadata examples and schema markdown files that are generated by the pre-build.py over at the ngff-spec repo, it will generate a frontmatter like this:

---
---

to make sure that we don't render the author information on every page of the examples and schemas section ^^"

@lubianat

Copy link
Copy Markdown
Contributor Author

Something that bumps me mildly is that the author information is rendered differently for the RFC document itself (the old table) and the reviews/comments/etc, where the frontmatter yaml is used.

@jo-mueller I think I don't get exactly what you mean here. Would you mind rephrasing your suggestion?

This comment was marked as outdated.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

This comment was marked as outdated.

This comment was marked as low quality.

@joshmoore

Copy link
Copy Markdown
Member

Many thanks, @lubianat! In preparation for the hackathon, I'm merging. I went through the change log and checked what I could visually. There is still the potential that something will need updating but:

  • The reduction in duplication is a benefit.
  • There is a high probability of this conflicting.
  • Having this in place for the hackathon will have many more eyes on it, which I think will be positive.

I'm still open for changes to the model of what we're doing here, but I don't think we have to have it perfect before moving forward.

Kudos on your perserverance! 😉


Non-blocking thoughts while reviewing for merge:

image
  • The notes section can probably be reduced a bit.
  • RFC-5 can have 0.6 listed.
  • We might want to list the version for RFCs 3 & 4
  • "Date" might could be split in started/finished
image
  • I'd likely separate endorsers from authors.
  • Perhaps all the blocks could be reduced in size.
  • Maybe a more tree layout?

A final thought (depending on whether or not we move the rfc/ material to its own repo), the code might should be in a library that can be tested separately.

@joshmoore
joshmoore merged commit 56e3d0a into ome:main Oct 23, 2026
5 checks passed
@imagesc-bot

Copy link
Copy Markdown

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/ngff-weekly-dev-update-thread/110810/163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation infra Concern: basic infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants