feat(client): disclosure chevron direction, inline-left automatch checkbox, 16px section headings - #134
Merged
Conversation
…ckbox, 16px section headings Disclosure chevrons now follow the standard convention — collapsed points right (.chevron rotate(-90deg)), expanded points down (.chevronOpen none) — across all four disclosure sites; .chevronFlip is untouched. The roleAutoMatch row regains flex via a .checkboxRow class rule (the .fieldset > .checkboxRow child selector stopped matching when the row moved inside the advanced body) with the input as the row's first child and the description as a second htmlFor label: checkbox inline-left, whole text row clickable, InfoHint still a label-text sibling (QC W-2). Section headings enlarged 14px to 16px (line-height 20px to 24px).
…text The description resolves to the same checkbox via getByLabelText (label association, not click-forwarding), and the input is the row's first child in DOM order. Existing automatch pins stay unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up UX round on the Fallbacks card from the maintainer's live-host review of #132 (plan
fallbacks-card-ux-followup):.chevron { transform: rotate(-90deg) }), expanded point down ˅ (.chevronOpen { transform: none }). Fixes all four disclosure sites at once (高级选项 toggle, time-slot rows, role rows, persona rows); the move-up.chevronFlipaffordance is untouched..fieldset > .checkboxRowstopped matching after the row moved inside#fallbacks-advanced-body, so the checkbox wrapped below the two-line label block. The rule becomes a.checkboxRowclass rule, the input moves to the first child position (checkbox inline-left, matching the card's optionRow convention), and the description becomes a second<label htmlFor>so the whole text row toggles the control. InfoHint stays a sibling of the label-text elements (W-2 a11y contract).Test plan
pnpm typecheck/pnpm buildexit 0tests/fallbacks-card.spec.tsx94/94 green (existing automatch pins untouched; new pin: input precedes label text, title + description both resolve to the same checkbox viagetByLabelText).changes/unreleased/card-ux-followup.md(Changed)🤖 Generated with ZCode