fix(panel): keep question prompts inside the card padding - #95
Merged
Merged
Conversation
A visible fieldset legend is painted on the border, so the prompt sat on the top edge and no longer lined up with the options. Render the prompt in normal flow and center option radios.
Index, header, and detail distinguish repeated prompts, so the clipped fieldset name has to carry them. Hide the visual copy from assistive tech so the group is announced once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fieldsetlegend, so the browser painted that text on the border and ignored the card padding.Test plan
ask_usercard no longer clips the title against the top edgeThe PR appears safe to merge with no outstanding findings.
Summary
Keeps question prompts within the card’s padded content area while preserving the fieldset’s complete accessible name.
Reviews (2) · Last reviewed commit: "fix(panel): include question context in ..."