Skip to content

fix(panel): keep question prompts inside the card padding - #95

Merged
Lum1104 merged 2 commits into
omdsh-dev:mainfrom
zzalancelot:fix/question-card-alignment
Sep 20, 2026
Merged

Lum1104 merged 2 commits into
omdsh-dev:mainfrom
zzalancelot:fix/question-card-alignment

Conversation

@zzalancelot

@zzalancelot zzalancelot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The confirmation card rendered its prompt inside a fieldset legend, so the browser painted that text on the border and ignored the card padding.
  • The prompt now stays in normal flow, lined up with the options, and option radios are vertically centered.

Test plan

  • Preview the question card: prompt sits inside the gray panel padding and shares the options' left edge
  • Radio is vertically centered in a two-line option
  • Reload the extension and confirm a live ask_user card no longer clips the title against the top edge

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no outstanding findings.

Summary

Keeps question prompts within the card’s padded content area while preserving the fieldset’s complete accessible name.

  • Moves the visible prompt into normal document flow and hides the duplicated visual content from assistive technology.
  • Builds the hidden legend from the question index, header, question, and detail.
  • Adjusts card and option spacing and vertically centers radio controls.

Reviews (2) · Last reviewed commit: "fix(panel): include question context in ..."

A visible fieldset legend is painted on the border, so the prompt sat on the top edge and no longer lined up with the options. Render the prompt in normal flow and center option radios.
Comment thread extensions/dsh-browser/src/panel/QuestionCard.tsx Outdated
Index, header, and detail distinguish repeated prompts, so the clipped fieldset name has to carry them. Hide the visual copy from assistive tech so the group is announced once.
@Lum1104
Lum1104 merged commit fce0a26 into omdsh-dev:main Sep 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants