feat(panel): show scroll-to-bottom control when not at latest - #90
Open
zzalancelot wants to merge 5 commits into
Open
zzalancelot wants to merge 5 commits into
zzalancelot wants to merge 5 commits into
Conversation
Add a floating chevron over the conversation pane so users who scrolled up can jump back to the newest messages, and only auto-follow while already near the bottom.
Observe the conversation scrollport with ResizeObserver so sibling UI that changes layout still keeps the jump-to-latest control accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
~/.dsh/browser-extensionpnpm --filter dsh-browser-extension exec vitest run tests/scroll-bottom.spec.ts tests/panel-styles.spec.tsThe PR appears safe to merge, with the previously reported stale bottom-state issue resolved by observing the actual scrollport.
Summary
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Conversation geometry or scroll changes] --> B[Measure distance from bottom] B --> C{Within 48 pixels?} C -->|Yes| D[Keep following new messages] C -->|No| E[Stop automatic scrolling] E --> F[Show scroll-to-latest control] F -->|User clicks| G[Smooth-scroll to bottom] G --> DReviews (2) · Last reviewed commit: "fix(panel): resync scroll-bottom state o..."