fix(browser): honor active=false for browser_open_tab

[zzalancelot]

Summary

• Fix browser_open_tab so callers can pass active (default true); active:false opens in the background and keeps the current visible tab in front.
• Thread active through to chrome.tabs.create and bind background opens with rebindControlled instead of always forcing the new tab forward.
• Update approval copy and EN/ZH docs; add coverage for schema forwarding, dispatch behavior, and approval summaries.

Test plan

• pnpm --filter @yuxianglin/dsh-bridge-browser test
• pnpm --filter dsh-browser-extension test
• Manually: browser_open_tab({ url, active: false }) keeps the current tab focused while the new tab becomes controlled
• Manually: default browser_open_tab({ url }) still activates the new tab

Confidence Score: 5/5

The implementation appears safe to merge, though the non-blocking route-level coverage gap remains.

Findings

1.  Binding branch lacks coverage ▶

Summary

• Adds the optional active argument to the bridge tool schema and forwards it through tab creation.
• Uses controlled affinity for background tabs while retaining active affinity for foreground tabs.
• Updates approval summaries, documentation, and focused affinity/dispatch tests.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[browser_open_tab] --> B{active is false?}
  B -- No --> C[Create active tab]
  C --> D[rebindActive]
  B -- Yes --> E[Create background tab]
  E --> F[rebindControlled]
  D --> G[Later tools target new tab]
  F --> G

Loading

_{Reviews (4) · Last reviewed commit: "fix(browser): honor active:false for bro..."}

[greptile-apps]

Binding branch lacks coverage

The new background-open binding branch is not exercised by the added tests. The test in background-tools.spec.ts replaces bindCreatedTab with a mock, so it verifies background tab creation but not that routeToolCall selects rebindControlled and makes the new tab the target of later browser tools. A route-level test should cover active:false through the real affinity binding; otherwise, a wiring regression could make later tools target the wrong tab while the current tests still pass.

[greptile-apps]

Want your agent to iterate on Greptile's feedback? Try greploops.