fix(browser): connect remote --host 0.0.0.0 bridge clients - #100
Open
zzalancelot wants to merge 2 commits into
Open
zzalancelot wants to merge 2 commits into
zzalancelot wants to merge 2 commits into
Conversation
Derive /ext/bridge-config wsUrl from the request Host and allow EXT_CONNECT_SRC to append LAN origins to the extension connect-src CSP at build time so remote deployments match the documented flow.
Scheme-wide connect-src already allows any ws/http(s) host, so a remote client can paste ws://<host>:<port>/ext/bridge instead of rebuilding the extension for each LAN address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97
Remote clients could not reach a
--host 0.0.0.0bridge even when the panel address and token were correct./ext/bridge-configalways returnedws://127.0.0.1, so discovery handed a LAN client a URL that only works on the host.connect-srconly allowed loopback, so Chromium blocked the WebSocket before the panel settings were used./ext/bridge-confignow buildswsUrlfrom the requestHost(andX-Forwarded-Host/X-Forwarded-Protowhen present).connect-srcallows anyws/wss/http/httpshost, so the panel can be set tows://<host>:<port>/ext/bridgewithout rebuilding for each LAN address. Non-loopback clients still need the host bridge token.