Adapt accessibility core to DSH 0.1.7-alpha.1 - #4
Conversation
# Conflicts: # .agents/notes/implemented/process/2026-08-08-native-windows-pull-request-ci.i18n.yaml # .agents/notes/implemented/process/2026-08-08-native-windows-pull-request-ci.md # .agents/notes/implemented/process/2026-08-08-native-windows-pull-request-ci.zh.md # .github/workflows/ci.yml # apps/cli/tests/profiles/headless/tests/fixtures/deepseek-defaults.cordis.yml # apps/web/tests/expected/agent-preset-selection/menu.expected.md # apps/web/tests/live-interactions.e2e.ts # docs/config-catalog.i18n.yaml # docs/config-catalog.md # packages/bundle/headless/src/index.ts # packages/bundle/headless/tests/headless.spec.ts # packages/client/ui-chat/README.i18n.yaml # packages/client/ui-chat/README.md # packages/client/ui-chat/README.zh.md # packages/client/ui-chat/src/client/chat/ChatView.tsx # packages/client/ui-chat/src/client/chat/MessageItem.tsx # packages/client/ui-conversation/src/client/skeleton/ConversationSession.tsx # packages/client/ui-conversation/tests/input-bar.client.spec.tsx # packages/client/ui-permission-presets/tests/permission-presets-row.client.spec.tsx # packages/client/ui-primitives/README.i18n.yaml # packages/client/ui-primitives/README.md # packages/client/ui-primitives/README.zh.md # packages/client/ui-settings-general/src/client/SettingsRoot.module.css # packages/client/ui-tool/src/client/tool/toolviews/bash-sample.tsx # packages/client/ui-trajectory/README.i18n.yaml # packages/client/ui-trajectory/README.md # packages/client/ui-trajectory/README.zh.md # packages/session/session-persistence-sqlite/tests/sqlite.spec.ts # packages/session/session-projection-cache/tests/cache.spec.ts # scripts/ci-workflow.spec.ts # snapshots/web/subagent-conversation/ui-expanded.expected.md # snapshots/web/subagent-conversation/ui.expected.md # snapshots/web/subagent-interrupt/offline-composer.expected.md
|
Pre-merge audit (2026-09-22): inspected tracked text in both workspaces (13,153 core files and 175 companion files), the additions in 39 core and 7 companion commits relative to the PR bases, and the companion npm dry-run inventory (126 files, including its generated source map). No real credentials, personal machine paths, or private intranet addresses were found in the adaptation changes or candidate package. Scanner hits in existing source were synthetic security-test inputs or unchanged upstream examples; this is a scoped review, not a comprehensive security certification. Current-revision local checks: core 41074ff + companion ae689cdc passed the five assembled browser tests (Chromium, Firefox, WebKit); 76 focused privacy/evidence/reading-view checks passed. Repositories are clean. These runs use synthetic/replayed conversations, not live-provider, VoiceOver/NVDA, or disabled-user evidence. Raw lab readiness logs are not public evidence and are not included in the npm package. No npm publication is authorized by this merge step. Preserve the pending human-AT status and historical evidence versions. |
|
Merge-check follow-up:
The merge target remains |
Windows follow-up; merge remains gatedThe a11y.3 run finished with 24 passing checks and one failure: Windows coverage. The Windows ACL runner suite passed all 19 tests. Two other tests failed:
Candidate The new CI run must pass in full, including Windows coverage, before merge to |
Verified merge completed
Before either final merge, core CI had 25 passing checks, including both Linux and Windows coverage, with no pending/failing checks. Three scope-conditioned jobs were skipped: upstream issue policy, Cloudflare preview and credential-dependent real-API E2E. Companion CI passed all eight checks. Neither PR had unresolved review threads; both exact heads and bases were rechecked before squash merge. The final core Linux instrumented run passed 33,723 tests with one expected failure and 121 conditional skips; its per-file coverage and uninstrumented-heavy gates passed. Remote Web replay passed 488 tests with 13 conditional skips. Final local follow-up evidence includes 112 focused core tests and five assembled external-plugin tests across Chromium, Firefox and WebKit. Earlier failed runs remain recorded separately. Both local worktrees are clean. No npm publication was performed. Real VoiceOver/NVDA and disabled-developer observations remain pending; these automated checks are not an accessibility certification. |
Targets official dsh-v0.1.7-alpha.1 exactly. Re-ports keyboard, focus, naming, live-announcement, quiet CLI, and reading-view ownership changes into the current Session V4/grouped conversation architecture. Preserves archived/pinned sessions and current settings/plugin surfaces. Includes narrow-viewport plugin inventory reflow and Firefox native scroll-container focus handling.
Local validation: official build and type checks; 7,396 GUI tests passed with 1 skip; 486 complete Web replay tests passed with 15 conditional skips; core accessibility Chromium 14 passed, Firefox/WebKit 13 passed plus 1 unsupported forced-colors skip each; companion assembled integration 5 passed; 42 documentation gates and 3 actual corpus checks passed. Historical Session generations remain intact; new V4 generations and shared-source references are validated.
Candidate tag: dsh-v0.1.7-alpha.1-a11y.2. No full accessibility or real-AT claim: VoiceOver/NVDA and disabled-developer task evidence remain pending. Existing human campaigns are not retargeted. This PR compares only against the exact official baseline, not the older fork master.
Follow-up validation (2026-09-22): core 41074ff repairs retired Windows test paths, upstream-only Project credentials, test unknown casts, and the migrated heartbeat fixture idle window. 124 focused tests passed; the final terminal recheck passed 20 tests and the corrected heartbeat scenario passed. Static rehearsal passed 57 gates; its two failed gates passed individual rechecks after repair. Prior full GUI/Web/browser results above belong to b11b37b. The first companion remote run passed all six OS/Node matrix jobs and assembled checks. New exact-revision remote CI is pending; do not treat it as passed or publish yet. Real assistive-technology evidence remains pending.