Split out of #246, which bundled three unrelated requests.
Now that the extension has a sidebar on Firefox (sidebar_action, #386) and a side panel on Chromium (side_panel, #356), there is no way to open either from the keyboard. src/manifest.json declares no commands key at all.
Firefox exposes _execute_sidebar_action as a special shortcut, so declaring it in commands gives users a bindable (and optionally default) shortcut in Manage Extension Shortcuts.
Chromium has no _execute_side_panel equivalent, so it needs a normal named command whose handler calls the same code path the toolbar click uses to open the panel.
Both branches would go behind the usual // @if BROWSER=... preprocessing, since the two halves are not interchangeable.
Worth checking whether a default binding is a good idea at all, or whether the command should ship unbound and let users assign it — extensions that claim a default chord tend to collide with each other.
Split out of #246, which bundled three unrelated requests.
Now that the extension has a sidebar on Firefox (
sidebar_action, #386) and a side panel on Chromium (side_panel, #356), there is no way to open either from the keyboard.src/manifest.jsondeclares nocommandskey at all.Firefox exposes
_execute_sidebar_actionas a special shortcut, so declaring it incommandsgives users a bindable (and optionally default) shortcut in Manage Extension Shortcuts.Chromium has no
_execute_side_panelequivalent, so it needs a normal named command whose handler calls the same code path the toolbar click uses to open the panel.Both branches would go behind the usual
// @if BROWSER=...preprocessing, since the two halves are not interchangeable.Worth checking whether a default binding is a good idea at all, or whether the command should ship unbound and let users assign it — extensions that claim a default chord tend to collide with each other.