feat(librarymanager): allow to use custom providers - #802
Merged
Conversation
tymonx
force-pushed
the
feature/custom-provider
branch
from
August 9, 2026 12:24
f631a27 to
4d3540b
Compare
tymonx
force-pushed
the
feature/custom-provider
branch
from
August 9, 2026 12:25
4d3540b to
9355587
Compare
tymonx
marked this pull request as draft
August 9, 2026 12:39
tymonx
marked this pull request as ready for review
August 9, 2026 12:43
Owner
|
Thanks! This looks like a nice cleanup. The original code was a bit messy so I haven't looked too closely at the logic changes. We should probably have some more tests here to help future changes, but that can be done separately. A note about library_root. The intention was to provide a way to set the default library location (i.e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #797
This PR allows to use custom providers to manage FuseSoC libraries.
Additionally:
Libraryclass to ownfusesoc/library.pymodule. This is required to avoid circular imports between provider and library manager. The implementation of theLibrary.update()method was moved to the library manager to break the circular import of theLibraryclasslocalprovider). Replaced strings likecheckoutthat are git specific withupdate/initializelibrary_rootattribute from the library manager. It was never used anywhere. Dead attributeLibraryManager.get_library()method for fast lookup by using dictionary instead of list