Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(dev): npm run dev:stack runs the full app from source (closes #65) #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(dev): npm run dev:stack runs the full app from source (closes #65) #367
Changes from all commits
e26eaf5File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: oll4com/spaceapp
Length of output: 12403
Script executed:
Repository: oll4com/spaceapp
Length of output: 12289
Script executed:
Repository: oll4com/spaceapp
Length of output: 13840
Stop the CI process group before running
reset.The CI job runs on Ubuntu, but
spawndoes not create a detached process group. During startup,uprunsdocker compose ... up --detach --waitthroughspawnSync, before it writes the PID file. If startup exceeds the readiness timeout,resetcan remove the compose resources while that child still runs.Start
upin a detached process group. SendSIGTERMto the group, wait forstackExited, then sendSIGKILLto the group if the bounded wait expires. Runresetonly after the second wait completes.Suggested fix
Uh oh!
There was an error while loading. Please reload this page.