Repository navigation
feat: add isolated from-source development stack - #251
Draft
345942185-eng wants to merge 29 commits into
Draft
345942185-eng wants to merge 29 commits into
345942185-eng wants to merge 29 commits into
Conversation
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Verify the original manifest snapshot independently from subsequent public contributions, then strictly verify the regenerated candidate before tests and builds. Signed-off-by: 秦世为 <345942185@qq.com>
Exercise the CI snapshot step against a real temporary Git history: allow later public edits while rejecting corrupted export manifests. Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Issue oll4com#65 explicitly states that reviewers ignore the expected outside-PR provenance failure. Preserve the upstream gate instead of changing its semantics. Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Fix MODULE_NOT_FOUND in Source stack / ubuntu-latest job 119704861837. Signed-off-by: 秦世为 <345942185@qq.com>
Regression for the hoisted executable path failure; verifies an actual child process serves the API readiness proxy. Signed-off-by: 秦世为 <345942185@qq.com>
Resolve /var versus /private/var before preparing state, matching the production launcher. Verified with a symlinked TMPDIR while retaining symlink refusal tests. Signed-off-by: 秦世为 <345942185@qq.com>
Use crypto.randomUUID() for the terminal clientId required by the API schema. Signed-off-by: 秦世为 <345942185@qq.com>
Update only the Vite lock entry within the existing supported semver range. npm audit --audit-level=high passed (0 high/critical; 7 moderate remain). Both real Vite HTTP/WebSocket tests passed under Node 24.19.0. Full Node 22 CI remains required. Signed-off-by: 秦世为 <345942185@qq.com>
Upgrade Hono to 4.13.13 and sanitize-html to 2.18.1, resolving the four findings in the filesystem Trivy report from run 39746048018. Regenerate the dependency lock without weakening scan thresholds. Validation: npm ci --ignore-scripts passed; application mail sanitizer assertions and Hono request smoke passed on Node 24.19.0. Full workspace tests require built internal packages and Node 22 CI verification. Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
Signed-off-by: 秦世为 <345942185@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and user impact
Contributors currently have to reconstruct installed-container configuration to run the complete application from their checkout. This adds an isolated source-development entry point for #65.
Closes #65.
Change
npm run dev:stackwithdown,resetandrebuild: PostgreSQL/Temporal in a checkout-specific Compose project, migrations, source API watch/Vite, built-from-source worker and CLI host.@opencode/clipin as well as the olderopencode-aispelling.Verification
Executed locally on Linux x86_64 with Node 22.23.0:
npm run check— passed.npm run build— passed.npm run hygiene:preflight— passed before commit.node --test scripts/tests/dev-stack.test.mjs scripts/tests/dev-stack-vite.test.mjs scripts/tests/public-export.test.mjs scripts/tests/public-package-metadata.test.mjs— 47 passed. This includes real HTTP and WebSocket proxy transport.vitest run tests/auth-dev-isolation.test.ts tests/auth.test.ts— 15 passed.npm test— blocked by the existing credential-agent test:listen EPERMfor its Unix socket in this execution environment. The full workspace suite therefore has not completed.Additional verification (2026-10-22)
ok: truealone..github/workflows/ci.ymland its workflow assertions to the upstream version. Issue [$450] One command to run the full SpaceApp stack from source for contributors #65 explicitly says the expected external-PR export provenance failure is ignored by reviewers.CI failure fixes (2026-10-22)
GitHub-hosted Linux acceptance (2026-10-22)
Source commit: bc12e2a.
Ubuntu job: https://github.com/345942185-eng/spaceapp/actions/runs/39744865646/job/119710702648 — passed.
This is real Docker/PostgreSQL/Temporal and OpenCode PTY acceptance, with no provider credentials. The source quality job has also passed typechecking; its remaining tests/build and macOS acceptance are still running. The earlier local Docker limitation below describes the local sandbox only, not this successful GitHub-hosted Linux run.
Dependency audit follow-up (2026-10-22)
Draft acceptance gaps
dev:stackwas checked to fail clearly at Docker preflight; a complete Docker startup/owner/OpenCode/reset run has not been executed.AI-assisted implementation and automated verification were performed with Codex. The submitting contributor's own review/manual testing remains pending. This PR stays a draft until the outstanding acceptance evidence is supplied.
Security, migration, resources and rollback
The development command creates only its own state/Compose resources and runs the existing migrations against a separate development database. It requires network access for pinned images/OpenCode and consumes local Docker resources. Temporal runs as container UID 0 to read the mode-0600 host-mounted Compose secret; no privileged mode or host-root mount is added.
downretains development data;resetremoves this checkout's development resources. Published installer/image behavior is unchanged.Signed-off-by:line; contribution under MIT.