Skip to content

CI gaps: viewer test:ci, pixel-rag:check, and the generated d.mts drift check #59

Description

@ohdearquant

CI currently builds the viewer and pins viewer/dist-static drift, but three checks the repo
already defines (or ships evidence for) never run in CI:

  • Viewer unit tests: npm --prefix viewer run test:ci exists in viewer/package.json
    but no CI job runs it. The test job stages the viewer (npm ci + build +
    git diff --exit-code -- viewer/dist-static) and stops there.
  • Pixel-RAG evidence check: pixel-rag:check validates the committed
    pixel-rag-bridge.json, but unlike its validators:check/firefly:check/
    preference-replay:check siblings it is not part of the build chain, so bridge drift
    lands silently.
  • Generated type-declaration drift: generate-validators.mjs --check compares only
    src/generated/report-validators.mjs; the committed report-validators.d.mts beside it has
    no drift check, so a schema change that regenerates the module but not the declarations
    ships a stale type surface.

All three are additive jobs/steps on the existing workflow — no new tooling.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions