box: a path resolved inside the box before the tree bound checks it, names with newlines, and the deadline handed through as given - #85
Open
ohdearquant wants to merge 4 commits into
Open
ohdearquant wants to merge 4 commits into
ohdearquant wants to merge 4 commits into
Conversation
…t, and a box run with no deadline is pinned
… still binds, and run hands its deadline through as given
…e NUL-ended paths or nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48, closes #47.
A path a command names is resolved inside the box before the tree bound checks it, so a symlink or a relative segment that leaves the tree is refused on what it resolves to, not on how it was spelled. The resolver ends each path with NUL and the reader splits on that, so a name holding a newline still binds to its own answer instead of shifting every line after it. The docker and remote transports take the deadline
runhands them as given, None included, and a test now spies that hand-over per transport.ADR-0011 states what holds, with the tests named.
Suite: 100% coverage on 3.11, 3.12 and 3.14; pre-commit clean.