chat: a continued chat runs in the box its log names, and is told when its saved patch is not applied - #72
Merged
Merged
Conversation
…n its saved patch is not applied Closes #59. The chat log's first row records where the chat ran (box and image); `lion chat -c` takes its box from that row unless a flag says otherwise, and when the earlier session's saved patch does not come off the directory as it stands, the model and the person are told so before the first turn. ADR-0018 S9 states the choice made and what holds.
The reverse-apply check of a continued session's saved patch ran git without catching its absence, so a resume on a machine without git stopped at startup. The check that cannot run is told to the model and the person as unchecked, and the resume goes on (ADR-0018 S9).
Owner
Author
|
One more: a resume whose saved patch cannot be checked (no git on the machine) now says so to the model and the person and goes on, where it stopped at startup before. Pinned with PATH stripped; S9 says it. |
# Conflicts: # docs/adr/INDEX.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59.
The chat log's first row records where the chat ran (box and image).
lion chat -ctakes its box from that row unless a flag says otherwise; a log without the row keeps the old defaults. When the earlier session's saved patch does not come off the directory as it stands, the model and the person are told so before the first turn.ADR-0018 S9 states the choice made and what holds.
Suite: 100% coverage on 3.11, 3.12 and 3.14; pre-commit clean.