chores: the catch-up asks the store for the actor's missed and failed rows, and reads their status where the store puts it - #71
Open
ohdearquant wants to merge 1 commit into
Open
ohdearquant wants to merge 1 commit into
ohdearquant wants to merge 1 commit into
Conversation
… rows, and reads their status where the store puts it Closes #54, closes #55. The missed-tick read passes creator and status to the store, one page each for missed and failed, so a busy namespace cannot push the actor's row past the page; the row's status is read at the item's top level, where the store returns it (it was read from properties, which never carry it, so no live row ever ran). A test drives a positive hand-run check. ADR-0015 states what holds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54, closes #55.
The missed-tick read passes the actor as creator and each of
missedandfailedas status to the store'slist, one page each, so a busy namespace cannot push the actor's rows past the page. The row's status is read at the item's top level, where the store returns it; it was read fromproperties, which never carry it, so no live row ever ran. A test drives a positive hand-run check end to end: the measurement printed, landed, and the identity released.ADR-0015 states what holds. The page cap itself (more than 200 of one actor's rows of one status) stays as S3 says and is filed separately.
Suite: 100% coverage on 3.11, 3.12 and 3.14; pre-commit clean.