core/odin: fold ternary-opeartor keyword special-casing into is_operator - #7411
Open
vivere-dally wants to merge 1 commit into
Open
core/odin: fold ternary-opeartor keyword special-casing into is_operator#7411vivere-dally wants to merge 1 commit into
vivere-dally wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reading through the parser logic because I am working on a toy lang and I wanted to learn some patterns, and I observed that
expect_operatorwas checking if the token is an operator, and the tokenizer method was a fallback which also checked for.If. Made the change locally, the tests are passing