Fix working_dir handling for os.process_start() on linux and posix - #7373
Open
BunterSchatten wants to merge 2 commits into
Open
Fix working_dir handling for os.process_start() on linux and posix#7373BunterSchatten wants to merge 2 commits into
BunterSchatten wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On linux and posix the
Process_Desc.working_dirforos.process_start()does not do what it should: As I understand it, the executable file should be searched in the current process working dir if it is not absolute, then the working dir of the spawned process should be changed toProcess_Desc.working_dir.Currently, the checks are run correctly against the current (parent) working dir, but the
execveatcall uses the newly setProcess_Desc.working_dir(if given) to resolve a relative exe path.I fixed that by always prefixing the executable name with the current (parent) working dir if it is not already absolute. This also makes the
execveatcall on linux needless, so I replaced it withexecve.On posix I also converted the string builder to a cstring before forking the process (like it is already done on linux).
This will break code that relies on the previous behaviour of searching the executable in the
Process_Desc.working_dir.