[core:test] Windows: Prevent exception handler from continuing. - #7086
Open
blob1807 wants to merge 1 commit into
Open
[core:test] Windows: Prevent exception handler from continuing.#7086blob1807 wants to merge 1 commit into
blob1807 wants to merge 1 commit into
Conversation
Idle in our Exception Handler, instead of continuing to next handler.
Contributor
|
Can confirm this passes all the cases in the #7035 issue I posted. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror POSIX and idle in our Exception Handler. Instead of continuing to next handler. This prevent Windows from close the process before the runner is done with its reporting.
I thought it was already doing this, but must of been getting lucky with Window's handler being or something.
Fixes #7035