Treat form feed character as whitespace in lexer - #7069
Open
remimimimimi wants to merge 1 commit into
Open
Conversation
Member
|
I have never heard of this feature in vim nor emacs, nor have anyone I have spoken to who actively use vim. Also, I didn't want to support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the lexer rejects the form feed character (
\f) when it appears between tokens. This PR adds support for treating it as whitespace.Form feed is conventionally used as a file-section separator by editors such as Emacs and Vim. This can be useful in large source files, where it provides a simple way to organize related declarations into sections and quickly navigate between them.
I also checked Sublime Text, VSCode, and CLion. They render this character explicitly so it is clearly distinguishable from space or tab characters. As far as I'm aware, there is no built-in support for navigating through file using form feed characters in those editors.
Although this changes the language’s lexical grammar, the implementation is very small. I opened a PR rather than only starting a discussion so that the proposed behavior and implementation can be reviewed and discussed together.