Repository navigation
fix(mcp): accept an identity's email address in from; add upstream tracking ledger - #37
Open
amirhmoradi wants to merge 3 commits into
Open
amirhmoradi wants to merge 3 commits into
amirhmoradi wants to merge 3 commits into
Conversation
…tracking ledger email_compose/reply/forward/edit and note_to_draft passed `from` straight through as identityId. No MCP tool lists identity IDs, so agents passed the sender address, got "Identity not found" and retried with the default identity. An address (contains "@") is now resolved case-insensitively via GET /identities (ungated read). An unknown address returns an error that lists the known addresses. Plain IDs pass through unchanged. Idea from vitalio-sh/thunderbird-cli#30. Also adds docs/upstream-tracking.md: watermark and triage ledger for the weekly upstream & forks scan, seeded from docs/PLAN.md (ODIAA-2402). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix:
email_compose,email_reply,email_forward,email_editandnote_to_draftpassedfromstraight through asidentityId. No MCP tool lists identity IDs, and the old description pointed at a non-existent "email_identities". Agents therefore passed the sender address, gotIdentity not found, and fell back to the default identity. Now:fromcontaining@is resolved case-insensitively viaGET /identities(already ungated inaccess-control.js, read-only).{ error: "No Thunderbird identity has the address … (known: …)" }without composing anything.MCP only. No new tool (counts stay at 74 CLI / 42 MCP). No change to
extension/,bridge/or the access policy. Idea from vitalio-sh/thunderbird-cli#30 (reimplemented; nothing copied).Docs: adds
docs/upstream-tracking.md, the state file for the weekly upstream & forks scan (ODIAA-2402). It holds the watermark (upstream465613d, last-seen SHA per fork, Thunderbird versions) and the triage ledger, seeded fromdocs/PLAN.md§3/§5, plus this week's 19 items and 3 similar-project ideas.Changes
mcp/src/tools.js:setIdentity()helper, wired into the 5 tools;fromdescriptions updatedtest/mcp-test.mjs:/identitiesmock; tests for address → ID and unknown address → errorskills/thunderbird-cli/SKILL.md:from: <identityId|email>CHANGELOG.md:### Fixedand### Docsunder[Unreleased]docs/upstream-tracking.md: newNote: #36 also adds a
### Securityblock under[Unreleased]. Whichever merges second needs a trivial CHANGELOG rebase.Tests
npm run test:all: pass (exit 0, all suites 0 failed; MCP 83/83)npm run test:pack-smoke: pass (10/10)🤖 Generated with Claude Code