chore: size scenario changesets as patch, not minor - #143
Merged
Conversation
The changeset from #133 was a minor, so the pending release PR proposed 0.5.0. That number is reserved for OCPP 2.0.1 in both ROADMAP.md and CURRENT_STATE.md, and spending it on one new scenario would push the 2.0.1 work to 0.6.0 and break the milestone-to-version mapping the project has held since v0.1. Retags the pending changeset to patch, so the release recomputes to 0.4.3. Adds the convention to the "Adding a Scenario" section, which did not mention changesets at all. A new scenario does add a public export, but scenarios are test corpus rather than consumer API surface: nothing is built against an individual scenario constant, and the registry is consumed as a whole through scenarios and getScenario(). #133 was asked for a minor during review, and #137, #138 and #139 are queued behind it. Closes #142
sepehr-safari
added
type:chore
This was referenced Jul 28, 2026
sepehr-safari
added a commit
that referenced
this pull request
Jul 28, 2026
…us work (#146) The living document drifted through two paths that bypass a normal feature PR: the release PR is created by the changesets action and never touches this file, and issue-only work leaves no PR at all. #137 through #140, #144 and the 0.4.3 release all landed without a record here. Records 0.4.3 (2026-07-28) and 0.3.2 (2026-07-14), the latter never logged at all, and corrects the package status table, which had read 0.3.1 since the v0.4.0 release. Adds a section covering the external contribution pipeline: the second good-first-issue completing, the patch-not-minor changeset decision (#142, #143), the detection-rule coverage audit that found 3 of 16 rules with no scenario, the three issues opened to close it, the retarget of #108 after its expectedFailures turned out to be unsatisfiable, and the station ID allocation across in-flight issues. It closes with the arithmetic to the v1.0 target of 20+ scenarios. Corrects an overclaim from #135, which described PR #133 as the first external contribution to a good-first-issue. It is the second: #105 carried the label and Develop-KIM completed it in #114, shipped in 0.3.1. Replaces "None currently. All design decisions resolved in ADRs" under pending decisions, since #144 carries four open questions. Closes #145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142.
The changeset that came in with #133 was a
minor, so the pending release PR#141 proposed
0.5.0. That number is reserved for OCPP 2.0.1 in bothROADMAP.mdandCURRENT_STATE.md. Spending it on one new scenario would pushthe 2.0.1 work to
0.6.0and break the milestone-to-version mapping the projecthas held since v0.1.
Changes
Retags the pending changeset to
patch, so #141 recomputes to0.4.3.Nothing has published yet, so this is free to change.
Adds the convention to "Adding a Scenario", which did not mention changesets
at all. That omission is how the wrong size arrived: #133 was asked for a minor
during review, and #137, #138 and #139 are queued behind it.
On the call itself
A new scenario does add a public export, so
minoris defensible read againstsemver alone. The argument for
patchis that scenarios are test corpus ratherthan consumer API surface: nothing is built against an individual scenario
constant, and the registry is consumed as a whole through
scenariosandgetScenario(). Reserving minor and major for changes to the analysis enginekeeps released version numbers lining up with the roadmap milestones.
Verification
pnpm format:checkandpnpm lintpass. No source or test files touched, so thesuite is unaffected.