Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readers polling an intermediate result file (e.g. a GUI) can see it truncated, because the ASCII and HDF5 writers open the destination with 'w' and write in place. For large results the write takes many seconds.
Both writers now write to a temporary file (the target path plus .tmp) and then os.replace() it into place. os.replace() is atomic, so a reader sees either the previous complete file or the new one. This makes the .bkp alternation in srwl_wfr_emit_prop_multi_e unnecessary, so it is removed. _file_bkp and _fbk are still accepted but ignored.