erddap-mcp: anchor the buoy live test to the dataset's maxTime, not now - #124
Merged
Merged
Conversation
test_get_tabledap_buoy queried PacIOOS wqb_04 with a rolling now-2days window. The buoy stopped reporting on 2026-08-13, so ERDDAP has answered every weekly run since with its "no matching results" 404 and the live job has been red for three weeks (issue #121). That is a sensor outage, not API drift, which is what test_live.py exists to catch. Look up the dataset's maxTime through allDatasets first and build the 2-day window from that, so the test keeps exercising the tabledap path (a string constraint plus two time constraints) regardless of whether the buoy is currently online. Verified live: all five erddap live tests pass against PacIOOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
Why
The weekly Live API Tests job has failed for
erddap-mcpon 2026-08-17, 08-24 and 08-31. The failing test,test_get_tabledap_buoy, queries PacIOOS buoywqb_04with a rollingnow-2dayswindow. Live check today:The buoy went offline on 2026-08-13. The client and the ERDDAP API are fine; the test was pinned to one sensor's uptime, which is not what
test_live.pyis meant to detect.What
wqb_04'smaxTimefromtabledap/allDatasetsfirst, then query a 2-day window ending at that timestamp.get_all_datasetswith a string constraint andget_tabledapwith two time constraints, so an upstream API or response-shape change would still surface.maxTime.Verification
uv run pytest tests/test_live.py -vagainst PacIOOS: 5 passed (was 1 failed, 4 passed).uv buildOK; ruff check/format clean.