Skip to content

Handle prepared-statement placeholders in plan monitor - #1256

Open
wayyoungboy wants to merge 1 commit into
oceanbase:masterfrom
wayyoungboy:fix-issue-420-ps-plan-monitor
Open

wayyoungboy wants to merge 1 commit into
oceanbase:masterfrom
wayyoungboy:fix-issue-420-ps-plan-monitor

Conversation

@wayyoungboy

Copy link
Copy Markdown
Member

Summary

  • make prepared-statement parameter filling skip ? inside strings, quoted identifiers, and comments
  • skip EXPLAIN extended when SQL audit text still contains unfilled parameter placeholders
  • add unit coverage for PS placeholder replacement and plan monitor EXPLAIN eligibility

Fixes #420

Verification

  • PYTHONPATH=. python -m pytest test/common/test_fill_sql_with_params.py test/gather/test_gather_plan_monitor_ps_sql.py test/common/test_scene.py -q
  • black --check -S -l 256 src/common/tool.py src/handler/gather/gather_plan_monitor.py test/common/test_fill_sql_with_params.py test/gather/test_gather_plan_monitor_ps_sql.py
  • python workflow_data/check_py_files.py .
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 使用ps协议的sql,无法正常获取plan_monitor

1 participant