Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

Grid cells of a lookup column show the raw foreign-key id in their hover tooltip, so hovering beside "Restricted record" (or beside a readable lookup's name) still reveals the id #13377

Closed

Description

@objectstack-fleet

Filing gate ① a user-visible defect with a named landing point and a reach. Filed by the objectui domain:ui seat 1 (seat post #5560, project run by the Sales account, session_01WJozybDmRH8z2c5SD7vJkj) from the review of PR #13376 (objectui#13335). ⛔ Not a claim. Grade and labels are triage's.

Who acts: the domain:ui seat 1, by a sub-agent, after triage grades it. It needs a contract-review pass at TIER_DEFAULT because it adds a member to the published TableColumn type.

Why (measured)

  • Page / persona: any object grid with a lookup / master_detail column; every viewer.
  • Now: the generic table's plain cell wrapper sets its title to String(cellValue) for every non-masked, non-object value. For a lookup column, cellValue is the referenced record's raw id. So hovering the empty space beside the cell's drawn name shows the id. After PR fix(fields): an unreadable lookup reads "Restricted record", not its raw id #13376, a lookup the viewer cannot read shows "Restricted record" with no id in its text, but the same hover still shows the id. objectui#13335's Done-when ("no link and no id … in grids") is met for the visible text and not for this tooltip.
  • Evidence: read in the DOM by the fix(fields): an unreadable lookup reads "Restricted record", not its raw id #13376 dev (its PR's Acceptance notes). Not checked in a real browser.

Landing (read on objectui origin/main 8cf3a86)

  • packages/components/src/renderers/complex/data-table.tsx, the cell wrapper's title={!isFit && !col.masked && cellValue != null && …} expression. objectui#10583 already drops this tooltip for masked columns, so the precedent is there.
  • The column reaching it carries no field type: ObjectGrid's last column pass runs normalizeTableColumnType (packages/types/src/data-display.ts), which keeps only the table's own types, so lookup / master_detail / tree arrive untyped. The same pass already carries two field-type facts through as TableColumn booleans, masked (objectui#10583) and chips (objectui#12708); neither can be reused (masked also blocks copy, CSV export and inline edit; chips only sets a width).
  • Measured shape of the fix (about 15 non-test lines, three packages): declare one optional TableColumn boolean for a reference column in @object-ui/types, set it in ObjectGrid's last pass from the column's type, and skip the tooltip for it in data-table.

Done when

  • Hovering a lookup / master_detail cell in a grid shows no tooltip carrying the raw id, for a readable and for a restricted reference.
  • Every other column keeps its tooltip (a plain text column still shows its value).
  • A grid pin for both, with a control.

Size: S.

Dedupe

Method: objectui issue search (repo-scoped, any state) on tooltip lookup id in titles at 2026-10-23T14:25Z: 3 hits, all closed and other surfaces: #5492 (the inline lookup dropdown's subtitle and option tooltip), #5195 (the lookup dropdown's recent-items filter), #2125 (the inline lookup editor's trigger). New.


Generated by Claude Code

Activity

  1. added
    area:recordsBusiness objects, records, the views that show data, usable forms, search
    bugSomething isn't working
    domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seat
    on Oct 23, 2026
  2. objectstack-fleet commented on Oct 23, 2026

    @objectstack-fleet
    ContributorAuthor

    Claim: PM loop round 4 · 2026-10-23T15:59Z
    Session: session_01WJozybDmRH8z2c5SD7vJkj (domain:ui seat 1; an S card done by a sub-agent of this seat, dispatched by this project's coordinator)
    Account: os-sales (the seat's linked user; the card's assignee)
    Branch: claude/issue-13377-lookup-cell-tooltip
    Worktree: objectui-issue-13377
    Domain: domain:ui
    Seat: domain:ui#1
    File surface: packages/types/src/data-display.ts (one optional TableColumn boolean for a reference column), packages/plugin-grid/src/ (ObjectGrid's last column pass sets it from the column's field type), packages/components/src/renderers/complex/data-table.tsx (the cell wrapper skips its title tooltip for it), tests beside, .changeset/ (one changeset) (stop on breach; explain in the report)
    Container & model: S, mode:subagent (a sub-agent of this seat, base origin/main), model: default, effort: medium (S)
    Clause-②: yes (widening: TableColumn gains one optional boolean; nothing is refused). The seat reviews the contract in-seat at TIER_DEFAULT before ACCEPT
    Responsibility: hovering a lookup / master_detail grid cell shows the raw foreign-key id in its tooltip, including beside "Restricted record" | any object grid with a reference column, every viewer | the id the cell's text withholds is still shown
    Serial constraints cleared: PR #13376 (objectui#13335, which filed this card) merged before this claim; no open PR touches these paths (the open PRs' file lists read in this act)

  3. objectstack-fleet commented on Oct 23, 2026

    @objectstack-fleet
    ContributorAuthor

    Claim amendment · domain:ui seat 1 · session_01WJozybDmRH8z2c5SD7vJkj · 2026-10-23T16:33Z

    File surface, widened by one file: content/docs/components/complex/data-table.mdx. Its Schema block lists the TableColumn members masked and chips. AGENTS #2 asks the docs to move with the change, so the new optional foreignKey member PR #13401 adds gets its one line there, in the same PR.

    Nothing else changes in the claim.


    Generated by Claude Code

  4. objectstack-fleet commented on Oct 23, 2026

    @objectstack-fleet
    ContributorAuthor

    LANDED

    objectui#13377 由 PR objectui#13401 合入 main,合并提交 f1a4b08958ac0100db2cc09961fb409fb690f4d2(2026-10-23T17:36Z,经合并队列)。记录于 2026-10-23T18:45Z。

    Seat: domain:ui#1

    落地内容:网格里查找类列(lookup、master_detail、tree、user)的单元格不再在悬停提示里显示被引用记录的原始 id,可读和受限的引用都是;其他列的提示不变。@object-ui/types 的 TableColumn 新增可选成员 foreignKey(合同复核 PASS)。合并时 Closes 已关本卡。

    撤下 pm:dispatched。席位核对见 PR comment 6370623661。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:recordsBusiness objects, records, the views that show data, usable forms, searchbugSomething isn't workingdomain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatpriority:p3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions