[objectstack-fleet]

Requested by Tesla · project thread

Part of #25921 (batch 10, claim 6691851032 with amendments 6691892486 naming the branch and 6691972228 naming the batch; the card's other open items stay on it)

Clause-②: no (narrowing)
Metadata-protocol: none

维护者速读

• 改了什么：从 @object-ui/types 的 spec-report.ts（入口上的 "Spec Report Bridge" 一组）删除 9 个没人读的名字：SpecReportChart、SpecReportChartInput、SpecReportChartSchema、SpecReportTypeEnum、SpecReportAggregate、QLAggregationFunction、mapAggregateToQL、JoinedSpecReport、isJoinedSpecReport。
• 为什么改：retire the zero-consumer surface: nine dead modules (2,211 LOC), plugin-ai, runner's publish flag, test-only reset helpers on public barrels, the providers trio, 122 dead i18n keys, root orphans #25921 清理零消费者公开面；这 9 个名字在仓内与 hotcrm 都没有任何引用（只剩 CHANGELOG 记录行），其中 4 个只是 @objectstack/spec/ui 已有符号的改名转出，留着会被当成 UI 协议包的公开承诺。
• 风险与回滚：其中 mapAggregateToQL、isJoinedSpecReport 是运行时函数，dist 也随之删除；仓内无调用方，Console 与各 @object-ui/* 包不受影响。对外部 npm 使用者是破坏性变更，带一个 ! patch changeset（BREAKING、FROM/TO、ADR-0087 runtime-export-retired 9 个）。回滚即 revert 本 PR。
• 先看：ui/packages/types/src/spec-report.ts（删掉的声明与两条 spec 导入）、.changeset/25921-types-spec-report-bridge.md（迁移说明）、ui/packages/types/src/__tests__/report-chart-query-spec-parity.test.ts（按席位裁决 A 删掉两条 JoinedSpecReport.blocks 派生钉子，JoinedReportBlock 的钉子全部保留）。
• 两分钟验证：git grep -lw -e mapAggregateToQL -e JoinedSpecReport -- ui/packages 预期只命中 ui/packages/types/src/index.ts 的退役注释（及 CHANGELOG）；pnpm --dir ui exec vitest run packages/types/ 预期全绿。
• 需要你做的：无，席位落地。

What changes

@object-ui/types (its . entry) loses 9 names of src/spec-report.ts, the entry's "Spec Report Bridge" block. They are deleted from the module, not only from the entry:

SpecReportChart, SpecReportChartInput, SpecReportChartSchema, SpecReportTypeEnum, SpecReportAggregate, QLAggregationFunction, mapAggregateToQL, JoinedSpecReport, isJoinedSpecReport.

• src/spec-report.ts: the chart type pair and the SpecReportChartSchema / SpecReportTypeEnum constants go, with the four @objectstack/spec/ui imports only they read (ReportChartParsed, ReportChart, ReportChartSchema, ReportType); the "Aggregate mapping" section (QLAggregationFunction, mapAggregateToQL) and SpecReportAggregate go, with the header's "Aggregation naming" paragraph that pointed at them; JoinedSpecReport and isJoinedSpecReport go. The rest of the module stays as it was: SpecReport, SpecReportInput, SpecReportTypeName, SpecReportDateGranularity, SpecReportSchema, the SpecReport factory, LegacyReportPresentationLike, specReportToPresentation, isSpecReport, JoinedReportBlock.
• src/index.ts: the block's two named lists lose the 9 names; a comment names them (retire the zero-consumer surface: nine dead modules (2,211 LOC), plugin-ai, runner's publish flag, test-only reset helpers on public barrels, the providers trio, 122 dead i18n keys, root orphans #25921) and where the four spec re-exports' originals live.
• .changeset/25921-types-spec-report-bridge.md: one ! patch changeset, BREAKING, FROM/TO per name (the chart trio and SpecReportTypeEnum → ReportChartParsed / ReportChart / ReportChartSchema / ReportType of @objectstack/spec/ui; the aggregate trio and the joined pair → no replacement, with the one-line rewrite for the guard), and the ADR-0087 runtime-export-retired marker naming all 9.

spec-report.ts is reached only through the . entry; no subpath entry of the package exports it.

Tests

Seat ruling A (amendment 6691972228): only what pins a retired name goes; every other row stays.

• src/__tests__/spec-report.test.ts: the describe('mapAggregateToQL') block (2 tests) and its import go with the function; the schema, adapter and isSpecReport blocks stay.
• src/__tests__/spec-ui-schema-reexports.test.ts: the SpecReportTypeEnum toBeDefined line goes; the SpecReportSchema line stays as the control for the same assertion.
• src/__tests__/report-chart-query-spec-parity.test.ts: the two derivation pins on JoinedSpecReport.blocks (_joinedReportBlocksAreTheSpecReportBlocks, _joinedReportBlocksAreParsedTier, their PublishedJoinedBlocks alias and void lines), the JoinedSpecReport import, the JoinedReportBlockParsed import only they used, and the header prose naming them. Every JoinedReportBlock pin (state, derivation, member) stays. The file is compiled by the package's type-check (tsc -p tsconfig.test.json lists it).
• No ablation: a deletion of exports with no tested behaviour left behind. The reverse probe below is the proof that the built .d.ts is the one read.

Verification

Census (read-only, before any edit; origin/main 0306761, hotcrm 6961ab1)

• Tool: the batch 8 census (TS AST of every published ui/packages/* main entry; identifier-token index over every tracked file of both repositories minus CHANGELOGs, changesets, the lockfile and release notes; prose and tests count as consumers; then not taught in README/demo/docs and not named by a kept export's declaration). @object-ui/types: 716 entry names, 156 zero-outside, 54 candidates; spec-report.ts 10 of them. Note: this project's files ui-seat-3/r2026-11-06/25921-b10-census.md.
• git grep -lw per name: every hit outside ui/packages/types/ is a CHANGELOG record line (types, ui, app-shell, components, core); hotcrm 0 for all 9.
• Readers among the 9 are each other only (mapAggregateToQL's signature names SpecReportAggregate / QLAggregationFunction; isJoinedSpecReport names JoinedSpecReport). No zod twin, not an arm of AnySchema, no subpath entry, not taught.
• Kept on rule 3 although the tool listed it: SpecReportDateGranularity, reached through specReportToPresentation → LegacyReportPresentationLike.groupBy[].dateGranularity (the tool's one-level proxy does not see the transitive reach).
• Positive controls, same module, same tool: specReportToPresentation (4 files outside the package), isSpecReport (1).
• No pending changeset names any of the 9; none of the 29 open PRs touches ui/packages/types/.

Local runs on head 6db3704 (base 0306761)

• env -u OS_SKIP_DTS pnpm --filter '@object-ui/types...' build (fresh worktree, no prior dist): VERDICT command-exit 0. Built dist: 0 files name mapAggregateToQL, isJoinedSpecReport or SpecReportChartSchema; the control specReportToPresentation is in 5.
• pnpm --filter @object-ui/types run type-check (src, examples, and tsconfig.test.json, which lists report-chart-query-spec-parity.test.ts) and pnpm --dir ui exec vitest run packages/types/: VERDICT command-exit 0; Test Files 387 passed (387), Tests 10460 passed (10460) (batch 9's 10462 minus the two mapAggregateToQL tests).
• Reverse probe against the built dist/index.d.ts: a scratch file importing the 9 names plus the controls isSpecReport and specReportToPresentation, tsc --noEmit --module nodenext: 9 errors (TS2305 / TS2724, one per retired name), 0 on the control line.
• node scripts/pm/dispatch-gates.mjs --commands on a63b2a0: 36 derived families, every line run with stdin closed, all exit 0 (pnpm --dir ui exec vitest run scripts/: Test Files 170 passed, 2 skipped (172), after building @objectstack/client... and @objectstack/formula... in this fresh worktree first); --ran reconciliation: 36 run, 0 NOT-MEASURED, 0 UNRUN.
• origin/main merged (9 commits, none under ui/packages/types/) → head 6db3704; the derivation is byte-identical. Re-run there with stdin closed, all exit 0: check-adr-0087-registration --base origin/main, check-changeset-no-major, check-empty-changeset, check:type-check-coverage, check:type-check-debt (first attempt exit 3 while the dogfood build held the verify lock; rerun after it: exit 0, "0 raw tsc error(s) total"), check:test-source-alias, check:cross-package-test-inputs, check-sdui-manifest, check:nul-bytes.
• node scripts/check-platform-checklist.mjs --changed-from origin/main: exit 0 (0 anchored files). pnpm --dir ui run check:new-line-citations: 0 new citations.
• Full dogfood (owed by the (narrowing) arm), head 6db3704: bash scripts/pm/os-verify-lock.sh -c "env -u OS_SKIP_DTS pnpm --filter '@objectstack/dogfood^...' build && pnpm --filter @objectstack/dogfood test": VERDICT command-exit 0; Test Files 428 passed, 3 skipped (431); Tests 3562 passed, 41 skipped (3603).
• Records: this project's files ui-seat-3/r2026-11-06/25921-b10/ (gates-ran-a63b2a0f.list, gates-ran-6db37048.list, reverse-probe.txt).

Acceptance notes

• Still open on retire the zero-consumer surface: nine dead modules (2,211 LOC), plugin-ai, runner's publish flag, test-only reset helpers on public barrels, the providers trio, 122 dead i18n keys, root orphans #25921 after this batch: clearSharedDiscoveryCache (needs a test-support home first) and the other barrel batches. @object-ui/types keeps about 45 more candidates (product-blocks.ts / designer.ts whose census hits are reached through kept unions, data-protocol.ts 6, ui-action.ts 4, the @objectstack/spec/ui re-exports 7 and others). Census and tools: this project's files ui-seat-3/r2026-11-06/25921-b10-census.md.
• types/src/ai.ts keeps its never tombstones until the sunset rule of docs/adr: a sunset rule for @deprecated tombstones — 574 tags (504 in packages/types, 640 'never' members) with no rule for when a tombstone leaves the authoring face #25912; not touched here.

---

Generated by Claude Code

🤖 Generated with Claude Code

https://claude.ai/code/session_01L9qibyCtmv9kCQuHZPh6eW

[objectstack-fleet]

domain:ui#3 · os-tesla · session_01L9qibxW6qraU2Z3mwupUGp

Contract-review-claim: session_01L9qibxW6qraU2Z3mwupUGp · head 6db3704 · 2026-11-06T19:29Z

[objectstack-fleet]

domain:ui#3 · os-tesla · session_01L9qibxW6qraU2Z3mwupUGp

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 6db370485a17b3faa319e5c83b1e61a3d0d8f08f
Local-runs: none
Scope: the PR's six files at head (.changeset/25921-types-spec-report-bridge.md, ui/packages/types/src/spec-report.ts in full, ui/packages/types/src/index.ts lines 810-990, ui/packages/types/src/__tests__/report-chart-query-spec-parity.test.ts lines 775-960, ui/packages/types/src/__tests__/spec-report.test.ts in full, ui/packages/types/src/__tests__/spec-ui-schema-reexports.test.ts around line 186) and their merge-base (41dc302) versions; cited files ui/packages/types/package.json (exports), ui/packages/types/tsconfig.test.json, packages/spec/src/ui/index.ts and packages/spec/src/ui/report.zod.ts (replacement names), .changeset/config.json (fixed group), scripts/check-adr-0087-registration.mjs (parseExportOperand, OPERAND grammar, readFromBlock, verifyRuntimeExportRetired, dispatch), scripts/check-changeset-no-major.mjs lines 57-100, scripts/pm/clause2-line.mjs lines 85-121; precedent changesets at ac5d0ce (batch 9) and 2cf269f (batch 8); PR #31038 body, seat amendment 6691972228, os-dev-report 6693532486; hotcrm at 6961ab1.

① Derived judgments

• Diff basis: merge-base 41dc302; git diff origin/main...6db37048 is exactly the 6 files, +43/-156; one content commit a63b2a0 plus the merge of origin/main.
• Unread outside declaration: on the head tree, git grep -nwE for the 9 names over the whole repo (minus CHANGELOG.md and .changeset/) hits only the retirement comment in ui/packages/types/src/index.ts 965-969. No homonym declaration exists anywhere. On the merge-base the same grep hits only spec-report.ts, index.ts and the three edited tests.
• hotcrm (6961ab1): 0 hits for the 9; it reads no kept spec-report name either.
• Kept-surface dependency: what remains in spec-report.ts (SpecReport, SpecReportInput, SpecReportTypeName, SpecReportDateGranularity, SpecReportSchema, the factory, LegacyReportPresentationLike, specReportToPresentation, isSpecReport, JoinedReportBlock) references none of the 9; the four spec imports only they read are gone with them. LegacyReportPresentationLike.aggregation is its own union. No zod file, AnySchema/union or kept export names a deleted symbol. No d.ts break.
• Subpaths: ui/packages/types/package.json exports reach spec-report.ts from . alone.
• Docs/README: none teach any of the 9. No export-census snapshot test enumerates entry names; ui/scripts/check-spec-symbol-derivation.mjs names none.
• FROM/TO targets exist in packages/spec/src/ui/report.zod.ts (ReportType, ReportChartSchema, ReportChart, ReportChartParsed) re-exported by packages/spec/src/ui/index.ts:42; no per-column aggregate remains in the spec (grep), so "no replacement" for the aggregate trio is right.
• Test comparison, old vs new:
  • spec-report.test.ts: only describe('mapAggregateToQL') (2 cases), its import and header bullet removed; the SpecReportSchema parsing (2), specReportToPresentation adapter (4) and isSpecReport type guard (3) blocks are byte-identical to main.
  • spec-ui-schema-reexports.test.ts: only expect(Types.SpecReportTypeEnum).toBeDefined() removed; Types.SpecReportSchema stays as the control.
  • report-chart-query-spec-parity.test.ts: removed PublishedJoinedBlocks, _joinedReportBlocksAreTheSpecReportBlocks, _joinedReportBlocksAreParsedTier, their void lines and the two imports used only by them. All 12 JoinedReportBlock pins on main survive on head, plus the installedSpecTyping tripwire; the file is still compiled by tsc -p tsconfig.test.json. No parity pin on a kept name is weakened.
• Precedent: batches 8 (refactor(types)!: delete the fifteen driver and datasource interfaces nothing reads #30852) and 9 (refactor(types)!: delete the api-types module and its eight names nothing reads #31002) are on main with the identical changeset shape; their changesets are consumed.

② Semver level

'@object-ui/types': patch with ! and a **BREAKING** banner is the repo convention: @object-ui/types is in the fixed group of .changeset/config.json; check-changeset-no-major.mjs forbids major until GA and ties minor to the metadata protocol alone. Nothing in packages/spec or any *.zod.ts moves, so patch + BREAKING is right. Clause-②: no (narrowing) is the arm clause2-line.mjs defines for "not a widening, but breaking"; correct for an export deletion. ADR-0087: 9 operands parse as <package>#<Export>; predicate 1 holds (each exported from dist/index.d.ts at base, gone at head, including the two runtime values); predicate 2 holds (declared in spec-report.ts, not a *.zod.ts, no metadata surface imports them); predicate 3 holds (the five - FROM … TO … lines yield exactly the 9 spellings). Metadata-protocol: none is correct.

③ Boundary flags

None. No packages/spec path, zod surface, subpath entry, registered node type or stored shape changes. The only consumer-visible loss is nine @object-ui/types entry names (two runtime) with zero importers in the workspace and hotcrm; the four spec re-exports stay one import away under their upstream names.

④ Design judgment

Dead surface only. Four names were renames of @objectstack/spec/ui symbols; the aggregate trio translated a per-column aggregate the dataset-bound Report schema no longer has; JoinedSpecReport/isJoinedSpecReport wrapped SpecReport.blocks and nothing narrowed on them. The module keeps its purpose (the parsed/input pair, schema, adapter, guard, and JoinedReportBlock with all its pins). No capability is taken from a consumer; the changeset tells an external host what to write instead. Ruling A followed exactly.

Implemented-by: claude/project-thread-7r0p6j
Reviewed-by: session_01L9qibxW6qraU2Z3mwupUGp

VERDICT: PASS

[objectstack-fleet]

domain:ui#3 · os-tesla · session_01L9qibxW6qraU2Z3mwupUGp

维护者速读

• 改了什么：从 @object-ui/types 的 spec-report.ts 删掉入口上「Spec Report Bridge」那一组 9 个名字：SpecReportChart、SpecReportChartInput、SpecReportChartSchema、SpecReportTypeEnum、SpecReportAggregate、QLAggregationFunction、mapAggregateToQL、JoinedSpecReport、isJoinedSpecReport。只钉这些名字的测试一并删掉（方案 A），JoinedReportBlock 的 12 条对齐钉全部保留。
• 为什么改：retire the zero-consumer surface: nine dead modules (2,211 LOC), plugin-ai, runner's publish flag, test-only reset helpers on public barrels, the providers trio, 122 dead i18n keys, root orphans #25921 清理零引用的公共面，这是第十批。工作区和 hotcrm 都没有读者；其中 4 个只是 @objectstack/spec/ui 已有符号换了个名字转出，聚合那三个对应的是报表协议已经去掉的按列聚合。
• 风险与回滚：只影响从包入口直接 import 这些名字的外部宿主（其中 mapAggregateToQL、isJoinedSpecReport 是运行时值）；changeset 标了 BREAKING 并给出 FROM → TO（改用 @objectstack/spec/ui 的 ReportChart / ReportChartSchema / ReportType 等）。回滚即撤本 PR。
• 先看：ui/packages/types/src/spec-report.ts 删掉的那一块，和 report-chart-query-spec-parity.test.ts 去掉的两条钉。
• 两分钟验证：cd ui && pnpm vitest run packages/types/src/__tests__/spec-report.test.ts 预期全绿；git grep -w mapAggregateToQL origin/main -- ui packages 合并后只剩入口注释。
• 需要你做的：无，席位落地。

席位核对 — ACCEPT · head 6db3704

• 形态：6 个文件，+43/−156。check-governed-merges --pr 31038：NOT governed，199 行 ≤ 3000。Part of #25921，目标 main。与认领 6691851032 及修订 6691892486（分支）、6691972228（批次与方案 A）一致。本 PR 由本席派出的卡线程实现，席位不写码。
• 契约：Clause-②: no (narrowing)，Metadata-protocol: none，! patch + BREAKING，ADR-0087 runtime-export-retired 9 个、FROM 段 1:1，与第八批 refactor(types)!: delete the fifteen driver and datasource interfaces nothing reads #30852、第九批 refactor(types)!: delete the api-types module and its eight names nothing reads #31002 同形。CONTRACT_REVIEW_TIER（Fable）复核 6693668398 在本 head 上 PASS，无必改项。
• 席位自己核对：读复核记录逐条对 diff：9 个名字在全仓与 hotcrm 无读者、无同名声明；剩下的导出不依赖它们；无子路径、无 zod 镜像；三个测试文件只去掉了钉退役名字的断言，SpecReportSchema / 适配器 / 守卫各段与 main 逐字相同。
• 前提实测：dev 报告 6693532486（status done）。types vitest 387 文件 / 10,460 条通过，type-check 含测试 0 错；构建产物 d.ts 反向探测 9/9 拒绝；派生门禁 36/36 exit 0；全量 dogfood 428 文件 / 3,562 条通过。
• 门禁 check-runs：本 head 每个检查最新一次 44 success、11 skipped，0 红；无冲突。
• 落地条款：维护者常设令 「你应该是使用 pm-dispatch 技能自主审核和落地 pr」（2026-11-06T14:09Z）。中继 pr_ready + automerge_enable。Part of：合并后 retire the zero-consumer surface: nine dead modules (2,211 LOC), plugin-ai, runner's publish flag, test-only reset helpers on public barrels, the providers trio, 122 dead i18n keys, root orphans #25921 退回 pm:queue、清 assignee、摘 pm:dispatched。