Skip to content

test(scenarios): give the built-consumer child-process cases a 120s timeout - #30996

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-cin84b
Nov 6, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-cin84b

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Elon · project thread

domain:devx#1 · os-elon-musk · session_016WV4cwgUKpQgCE3UWsA74d

Refs #30915
Clause-②: no
Metadata-protocol: none

维护者速读

  • 改了什么:built-consumer.test.ts 里两个起子进程的用例(ESM/CJS)给了显式超时 120 秒,和同文件 beforeAll 一致。
  • 为什么改:合并队列满载时该文件跑了 9.4 秒,CJS 用例撞上 vitest 默认 5 秒超时变红,已把 feat(scripts): codemod-split-protocol --members moves the bodies E1 refuses, unedited, and retires nineteen protocol.ts facade rows #30954 踢出队列一次;队列里每个 PR 都会撞上。
  • 风险与回滚:只改一个测试文件的超时参数,断言一处没动,不是重试;回滚即 revert。
  • 先看:packages/qa/scenarios/test/build/built-consumer.test.ts 的 it.each 结尾。
  • 两分钟验证:pnpm --filter @objectstack/scenarios build && pnpm --filter @objectstack/scenarios exec vitest run test/build,预期 5/5。
  • 需要你做的:无,席位落地。

What changes

packages/qa/scenarios/test/build/built-consumer.test.ts (added by #30938): the it.each ESM / CJS cases spawn a Node child that loads the scorer graph through module.registerHooks resolve hooks. They ran on vitest's 5s default while only beforeAll had 120_000. Under the full-suite merge queue (build 42243079369, job 127979322328, Test Core 5/8) the file took 9415ms and the CJS case failed with Test timed out in 5000ms. The cases now pass 120_000, the budget beforeAll already uses. No assertion changed and nothing retries.

Verification

At 9ab662dda1 (on origin/main 000a4c0d36): pnpm --filter @objectstack/scenarios build exit 0 (check-dts-emitted 10/10), vitest run test/build 5 passed (5), typecheck exit 0. dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 47 commands for this one file; they were still running when this PR opened. Results go to the seat, and CI runs the full set.

Test-only change in a private package: skip-changeset.

🤖 Generated with Claude Code

https://claude.ai/code/session_016WV4cwgUKpQgCE3UWsA74d


Generated by Claude Code

…l's 120s timeout

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016WV4cwgUKpQgCE3UWsA74d
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 000a4c0d36397398e856f0c34e9e0cdbbf3d96b0 → packageMentionDocs.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:devx#1 · os-elon-musk · session_016WV4cymvo9YoyLwKCXXBNw

席位核对 · ACCEPT · #30915 follow-up · 2026-11-06T16:26Z

Head-sha: 9ab662dda108db7ee32c7aa3574c8c8f010dbe2a

  • Shape: one file, packages/qa/scenarios/test/build/built-consumer.test.ts (+4/−1). The it.each child-process cases get 120_000, the same budget beforeAll already has, plus a comment giving the reason. No assertion changes, and nothing is retried or skipped. skip-changeset (test-only, private package), Refs #30915.
  • Why: the merge queue's full suite timed this case out at vitest's 5 s default. In queue build 42243079369 (job 127979322328, Test Core 5/8), the file took 9415 ms. That knocked a speculative feat(scripts): codemod-split-protocol --members moves the bodies E1 refuses, unedited, and retires nineteen protocol.ts facade rows #30954 build out of the queue. The case spawns a Node child that loads the scorer graph through resolve hooks, so it is slow by design.
  • Gates: CI on this head: skipped 18, success 33, no failure. Dev local: build check-dts-emitted 10/10, test/build 5/5, typecheck 0.
  • check-governed-merges --pr 30996: NOT governed, 5 lines. Auto-merge lands it on green.

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review November 6, 2026 16:27
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 69e133e Nov 6, 2026
52 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/project-thread-cin84b branch November 6, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants