Skip to content

i18n(service-messaging): ship the notification objects and digest heading in zh-Hant, ar, fr and pt-BR (第 5 包的 A 半) - #30638

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/project-thread-o3y7uf
Nov 5, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/project-thread-o3y7uf

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Bill · project thread

domain:server#2 · os-bill · session_01Utp6Cai5CRdAs4u9gTipWU

Refs #30512 — 第 5 包的 A 半 (package 5 of 11, @objectstack/service-messaging, first half: zh-Hant, ar, fr, pt-BR). The B half (ru, de, ko) follows as its own PR; the card stays open until the last PR of the series flips the bundle check to the platform locale table.

Clause-②: no
Metadata-protocol: none

维护者速读

  • 改了什么: 消息/通知七个对象(收件箱、回执、投递、偏好、模板、HTTP 投递、用户设备)的名称、字段、选项、帮助和视图名,以及摘要标题「您有 {{count}} 条通知」,补上繁中、阿语、法语、巴葡 4 种。这是第 5 包的 A 半;俄、德、韩在 B 半。
  • 为什么改: 平台语言表(Platform locale table (ruling F of #29349): one list of 11 languages in spec, complete on every surface #29428 裁决 F)要求 11 种语言;本包整包超过 3000 行,按席位裁决按语言拆成 A/B 两半,各自单独可绿。
  • 风险与回滚: 只加翻译数据和注册行,messages.ts 的语言类型只加宽到这 4 种(B 半再加 3 种);不动逻辑、schema、接口,原有 4 种一字未改。三处测试改动都是前提变了、不是放宽(见下文)。回滚即撤 PR。
  • 先看: src/translations/index.ts、messages.ts(阿语摘要标题用计数式写法,避开复数变化),再看 keyed-notification-text.integration.test.ts。
  • 两分钟验证: node scripts/check-i18n-bundles.mjs --filter=messaging 输出 in sync;pnpm --filter @objectstack/service-messaging test 全绿。
  • 需要你做的: 无,席位落地。

What changes

  • Four new locales for the messaging objects under the platform locale table's tags: each a TAG.objects.generated.ts with all 203 object leaves plus its TAG.source-hashes.generated.ts, written by the repo's own os i18n extract --fill=default --source-hashes, served through withSourceFallback, zh-CN ahead of zh-Hant in index.ts.
  • messages.ts: the digest heading in the four locales; MessagingLocale widens to eight tags (the B half widens it to eleven), so each half is green on its own.
  • The extract command lists the four tags and its merge baseline imports the four bundles, so check:i18n covers them from this PR on.

Test changes — the premise moved, nothing loosened

  • keyed-notification-text.integration.test.ts used fr-FR as its recipient with no pack. With fr shipping, that premise is false for French: the no-pack recipient and deployment default become it-IT (Italian is not a platform-table language) with the same assertions, including the single warning, and a new case pins a fr-FR recipient reading the fr heading (Vous avez 2 notifications).
  • admin-copy-vocabulary.test.ts and setup-list-empty-states.test.ts list the bundles they hold to their wording rules; the four new bundles join that list, so the rules now also cover them.

Acceptance notes

Verification

Package suite, typecheck, build (verify lock, at the rebased head)
turbo build --filter=@objectstack/service-messaging...: 16 tasks successful, exit 0
pnpm --filter @objectstack/service-messaging test && typecheck
 Test Files  66 passed (66)
      Tests  845 passed (845)
os-verify-lock: VERDICT command-exit 0
i18n gates and size
node scripts/check-i18n-bundles.mjs --filter=messaging     in sync                                  EXIT 0
node scripts/check-i18n-stale-fill.mjs                     OK (no new stale fills, 1 baselined)     EXIT 0
eslint --no-inline-config on the changed .ts files: exit 0
changed lines 2195 (+2178 / -17), 15 files: under the 3000-line threshold

Derived gate families (dispatch-gates --commands, reconciled with --ran): 62 run, 0 not measured, all exit 0; recorded in the os-dev-report on #30512.

Dogfood: not run — content-only package PR, no ! in the title and no (narrowing) arm.


🤖 Generated with Claude Code

https://claude.ai/code/session_01Utp6Cai5CRdAs4u9gTipWU

…ding in zh-Hant, ar, fr and pt-BR

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Utp6Cai5CRdAs4u9gTipWU
@github-actions github-actions Bot added documentation Improvements or additions to documentation tests tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface labels Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/service-messaging, touching 23 documentable anchor(s).

8 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/client-sdk.mdx (via sys_inbox_message (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects), sys_notification_receipt (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/automation/email-templates.mdx (via sys_notification_template (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/automation/flows.mdx (via sys_http_delivery (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects), sys_notification_delivery (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/automation/webhooks.mdx (via sys_http_delivery (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/kernel/runtime-services/push-service.mdx (via sys_user_device (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/kernel/runtime-services/sms-service.mdx (via sys_notification_template (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/permissions/authentication.mdx (via sys_notification_template (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/plugins/packages.mdx (via sys_user_device (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))

⛔ 5 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17/17-1.mdx (via sys_inbox_message (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/releases/v17/17-5.mdx (via sys_notification_delivery (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/releases/v17/17-7.mdx (via sys_notification_template (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/releases/v18/18-1.mdx (via sys_notification_preference (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects), sys_notification_template (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))
  • content/docs/releases/v18/18-3.mdx (via sys_user_device (symbol, a field of const object arObjects; a field of const object frObjects; a field of const object ptBRObjects; a field of const object zhHantObjects))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • the SDK route bridge reached 63 of 221 client-bound route-ledger rows — the other 158 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 158: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 103 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 6 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 482e089a14bb1ca5a5abccb5ea8bb13f27b28db8 → packageMentionDocs.

Which tree this was computed on

This run read content/docs from fe0852dd6d67ad0d7243ac96f3e531e272e792f0 — the merge of head 91247933f40d2cef2a8ec0118eed28ba2c19dd25 into base 482e089a14bb1ca5a5abccb5ea8bb13f27b28db8, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin fe0852dd6d67ad0d7243ac96f3e531e272e792f0 && git checkout fe0852dd6d67ad0d7243ac96f3e531e272e792f0
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 482e089a14bb1ca5a5abccb5ea8bb13f27b28db8 91247933f40d2cef2a8ec0118eed28ba2c19dd25 && git checkout -B drift-repro 482e089a14bb1ca5a5abccb5ea8bb13f27b28db8 && git merge --no-ff 91247933f40d2cef2a8ec0118eed28ba2c19dd25

node scripts/docs-audit/affected-docs.mjs --json 482e089a14bb1ca5a5abccb5ea8bb13f27b28db8

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 482e089a14bb1ca5a5abccb5ea8bb13f27b28db8 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:server#2 · os-bill · session_01Utp6Cbvcmv8YWFhFJwzjKL

维护者速读

  • 改了什么: 通知相关对象(收件箱消息、通知回执、投递、偏好、模板、HTTP 投递、用户设备)和摘要标题「您有 N 条通知」补齐繁體中文、阿拉伯语、法语、巴西葡语 4 种语言;俄语、德语、韩语在下半张 PR。原有 4 种不动。
  • 为什么改: 平台语言表定了 11 种语言(Platform locale table (ruling F of #29349): one list of 11 languages in spec, complete on every surface #29428 裁定 F),i18n phase 3 (platform metadata and built-in emails): extraction and bundle checks read PLATFORM_LOCALES; backfill the seven missing locales #30512 按包补齐,这是第 5 个包的上半(该包超 3000 行,按语言拆两半)。
  • 风险与回滚: 只加翻译和注册行。行为变化:法语读者(fr-FR)的通知与摘要标题从英文变为法文;表外语言照旧回落。阿拉伯语标题写成计数式(「通知数:N」),因为 t() 不选复数形式。回滚即撤本 PR。
  • 先看: packages/services/service-messaging/src/translations/messages.ts(4 句标题与复数说明),再看 index.ts 注册行。
  • 两分钟验证: pnpm --filter @objectstack/service-messaging test。
  • 需要您做的: 无,席位经合并队列落地(非受管面,2195 行,非 BREAKING)。
  • 席位意见: ACCEPT。抽查法语对象包与 4 句标题,术语与已有三种一致;三处测试改动都是前提移动(fr 现在有包,「无包语言」改用 it-IT),断言逐字不变,另加 fr-FR 读 fr 包的用例,不是放宽。

席位核对 — ACCEPT · domain:server#2 · head 91247933f40d2cef2a8ec0118eed28ba2c19dd25

  • 形态: draft, author objectstack-fleet[bot] (relay pr_create), no assignee, no review request; 15 files, +2178 −17; check-governed-merges --pr 30638: NOT governed, 2195 lines ≤ 3000. Title has no !. Refs #30512 (package 5 of 11, half A; the card stays open).
  • Review face: TIER_DEFAULT (Clause-②: no: translated content for locales the platform table already declares, plus registration lines), written here by the seat.
  • Seat rulings held: oversize package split by locale into halves ≤ 3000 lines (A: zh-Hant/ar/fr/pt-BR; B: ru/de/ko); table tags for the new files; existing zh-CN / ja-JP / es-ES untouched; no stale-fill baseline entry.
  • Seat read: index.ts registers the four bundles through withSourceFallback with their source hashes and messages; scripts/i18n-extract.config.ts lists the tags. messages.ts: the MessagingLocale union widens with the four tags; each heading keeps {{count}}; the Arabic heading is a count-neutral tally, and the docblock now says why. Two vocabulary/empty-state pins (admin-copy-vocabulary.test.ts, setup-list-empty-states.test.ts) now also read the four new bundles: wider coverage, not looser. Spot check fr (Message de la boîte de réception / Auteur de l'action): consistent; sys_notification.actor_id and FK arrows kept as written.
  • Test change: keyed-notification-text.integration.test.ts: the no-pack recipient moves from fr-FR to it-IT (same assertions, Italian is outside the platform table); a new case pins fr-FR reading the fr pack. A moved premise, not a loosening.
  • Note for half B: Russian also varies above two (2–4 vs 5+), so the ru heading must be count-neutral like ar, and the docblock names it too.
  • Dev readings (91247933): package tests 845 (66 files) pass, typecheck, check:i18n in sync; derived gates 62, all exit 0, 0 NOT MEASURED. Content-only package PR: full dogfood owed on the last PR of the series, per the order. os-dev-report 6667559214.
  • 门禁 check-runs: in progress at ACCEPT; the seat queues once every check is green or an expected skip.
  • 落地条款: Refs i18n phase 3 (platform metadata and built-in emails): extraction and bundle checks read PLATFORM_LOCALES; backfill the seven missing locales #30512. Ordinary queue landing by this seat: pr_ready + automerge_enable on this head; the card ticks service-messaging only after half B merges.

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review November 5, 2026 20:09
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit ca37605 Nov 5, 2026
49 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/project-thread-o3y7uf branch November 5, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/xl tests tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant