Repository navigation
fix(app-shell): zh-CN view properties panel reads the empty filter prompt and the description hint in Chinese - #30265
Conversation
…scription hint in Chinese Claude-Session: https://claude.ai/code/session_01WGufzgWrZ7dEo8uwMCqevS Co-authored-by: Claude <noreply@anthropic.com>
|
domain:ui#1 · os-support-ai · session_01WGufzfE4V9fzZgJLrLDmMC 维护者速读(席位终稿)
席位核对 · ACCEPT · head
|
⛔ merge queue 构建失败 — 先分诊,再决定要不要重排队列构建 41967589721 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集), 分类: 失败的 job(日志抽取,best effort):
跨 PR 相同签名(24h,按失败测试文件聚合):
历史信号:
分诊清单:
Generated by Claude Code · merge-queue-triage workflow (#4859) |
|
domain:ui#1 · os-support-ai · session_01WGufzfE4V9fzZgJLrLDmMC Queue ejection read · re-queued · 2026-11-05T04:49Z
|
Requested by Yibo Wang · project thread
Refs #30039
Clause-②: no
Metadata-protocol: none
维护者速读
ui/packages/app-shell/src/views/metadata-admin/widgets.tsx(筛选按钮取词)、metadata-form-zh-cn.ts(视图description的中文说明)。pnpm --dir ui exec vitest run packages/app-shell/src/views/metadata-admin/widgets.filterBuilderHeldRow-26738.test.tsx,预期全部通过,其中 objectstack#30039 一组断言中文为「+ 添加筛选…」、英文仍为「+ Add filter…」。What changes
Browser verification of #30039 (Acceptance 5) on a dev boot of the example CRM with the console in zh-CN found two English strings left at position 1, the view properties panel (
/studio/com.example.crm/interfaces?surface=view:crm_lead.all). Both are in the card's evidence list for that position:+ Add filter…: thefilter-builderwidget's empty trigger inwidgets.tsxwas an English literal. It now readsengine.inspector.dataset.addFilter, the Studio string the dataset scope filter (FilterConditionField) already uses for the same button, which has a zh row (+ 添加筛选…). The widget already heldlocalefromuseMetadataLocale().View description for documentation/tooltips: thedescriptionrow's hint was the spec schema's own.describe()text, because neither the form nor the platform's zh-CN metadata-forms bundle carries help for it. The zh-CN view overlay (metadata-form-zh-cn.ts) now gives that rowhelpText: '视图说明,用于文档与悬停提示'. The file's header said every leaf is copied from the platform bundle; it now names this kind of hand-worded leaf as the one exception and the row is marked.Changeset:
@object-ui/app-shellpatch.Verification
Boot: full
turbo run build --filter='!@objectstack/docs'at6f095b9cunder the verify lock (VERDICT command-exit 0),examples/app-crmobjectstack dev --seed-admin --fresh, console Vite pointed at it, Playwright Chromium withlocale: 'zh-CN', signed in as the dev admin. For positions 2 to 5 a writable packagecom.qa.zhtermswas seeded over the REST door: an object and a record-after-update flow saved active, then five drafts (object label change, flowstatuschange, new dataset, dashboard and permission set) with?mode=draft.GET /api/v1/automation/_statusanswered the flowbound: false,unboundCause: missing_trigger.+ Add filter…, the description hint). After: 基础信息 / 标识与主显示形态 / 描述 / 视图说明,用于文档与悬停提示 / 列与筛选 / + 添加筛选… / 可搜索字段 / 表格选项 / 终端用户控制 / 导航与共享30039-p1-view-panel.png30039-p2-p3-publish-sheet.png30039-p2-p3-publish-sheet.png30039-p4-flow-problems.png30039-p5a-palette-save-notice.png,30039-p5b-notify-template.png30039-p6a-rail-and-create-menu.png,30039-p6b-create-dialog.png,30039-p2-p3-publish-sheet.pngThe shots are in the project's
ui-orders/30039-shots/folder (2x, 1440 wide); this repository has no place to commit them, perui/AGENTS.mdHousekeeping.Tests at 808dbf8
pnpm --dir ui exec vitest runonmetadata-form-i18n.test.ts,widgets.filterBuilderHeldRow-26738.test.tsx,inspectorStrings.i18n-10586.test.tsxandSchemaForm.controlWidgetGridNaming-9889.test.tsx(every test file that reads either changed string or the filter trigger):Test Files 4 passed (4),Tests 75 passed (75), lock VERDICT command-exit 0.widgets.filterBuilderHeldRow-26738.test.tsxgains a top-leveldescribe(zh reads+ 添加筛选…and notAdd filter; en control reads+ Add filter…);metadata-form-i18n.test.ts's Studio on zh-CN still mixes languages and terms: view properties panel, flow nodes, publish sheet labels, and 仪表板 beside 仪表盘 #30039 group asserts the zhdescriptionhelp and that en has none.pnpm --filter @object-ui/app-shell run type-check(both tsconfigs): exit 0, VERDICT 0.Gates at 808dbf8
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack(5 paths vs merge base 6f095b9): 35 commands, all run under one lock (VERDICT command-exit 0), every one exit 0.--ranwith the exit codes recorded: 35 derived, 35 run, 0 NOT-MEASURED (a derived zero).pnpm --dir ui exec vitest run scripts/:Test Files 170 passed | 2 skipped (172),Tests 4985 passed | 2 skipped.Not run locally: the full ui suite.
origin/mainmoved to31260ca8after the branch point, touching none of this PR's files (one unrelated test undermetadata-admin); CI's Test UI shards run the suite.Acceptance notes
Enable column resizing,Row height / density setting, …) and every sub-field of theselection,pagination,userFilters,appearance,userActions,navigationandsharingcomposites (labels such asPage Size,Element,Allowed Visualizationsand its options, and their hints). None of them is in any catalogue: the platform zh-CN metadata-forms bundle carries only keys the form declares, and the overlay's composite rule forbids naming children the form does not declare (naming one would hide the rest). The lasting fix is upstream: the spec view form declares those sub-fields and hints so the extractor emits keys, the platform bundle translates them, and the overlay copies them. Shot:30039-p1b-view-panel-expanded-finding.png.All Leads, while the rail shows the translated 全部线索. Noted, not filed here.Generated by Claude Code