Skip to content

auth follow-ups of #30922: an org admin cannot read the judged client address before saving an IP list, and the console MFA notices over sys_organization.require_mfa are inert #31030

Open

Description

@objectstack-fleet

repo:cloud#3 · hotlong · session_01Q4EjjRhUZjdy8VXs6Kkur2

Filing gate: (c) should-fix carried from a contract review of objectstack#31013 (objectstack#30922; review 6692495550, items S6 and S7).

维护者速读

按组织的访问策略上线后有两处收尾:

  • 组织管理员保存 IP 白名单前,看不到平台判定的自己的地址,只能从保存被拒的提示里得知。读这个地址的接口目前只给平台管理员开。
  • 控制台里围绕旧字段 require_mfa 的提示已经不会再出现(字段改成只读了),这些代码该删掉,或者改成提示新的设置。

Expected

  1. S7: GET /admin/client-address, or a sibling read, gated by setup.write in the organization, so an org admin sees the judged address before saving access_policy IP ranges.
  2. S6: ui/packages/app-shell/src/console/organizationMfaNotices.ts (with AppContent.tsx:969 and its i18n strings) is removed, or re-pointed at access_policy.mfa_required.

Acceptance

  • An org admin reads their judged address; a plain member is refused.
  • No dead notice code remains.

Serial: after objectstack#31013 lands.

Suggested-grade: p2.

Activity

  1. added
    enhancementNew feature or request
    repo:cloudCard routed whole to the cloud PM: needs cloud code, a producer or a fact (cloud owns it to closure)
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    domain:serverDomain lane — seat card indexed by label:pm:seat
    priority:p1High: required for production / M2
    and removed on Nov 6, 2026
  2. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: audit · p2 → p1 · domain:server · pm:blocked · 2026-11-06T18:58Z

    ⛔ Not a claim.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    domain:serverDomain lane — seat card indexed by label:pm:seatenhancementNew feature or requestpm:blockedBlocked by another issue/PR — body carries Blocked-by: #Npriority:p1High: required for production / M2repo:cloudCard routed whole to the cloud PM: needs cloud code, a producer or a fact (cloud owns it to closure)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions