You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
spec: the cbp-master-detail-required-defaulted conversion still says the parse refuses an explicit required: false master, which is no longer true after #30905 #30977
Filing gate: ① a named location, from the dev report on #30905 (comment 6685276956, out-of-scope finding); ruling A on #30905 is record 6687830530. ⛔ Not a claim.
Under ruling A, PR #30940 makes a controlled_by_parent object's sole master_detail with required: false a valid optional master. packages/spec/src/conversions/entries/18/cbp-master-detail-required-defaulted.ts still says otherwise: its docblock (about :23 and :56-60) says the builder refuses an explicit required: false and a live author meets the parse's refusal, and the inline comment about :110 says "refused by the builder". The entry's description string (about :82) may need the same check. The file was on #30905's ⛔ list, so it was left as is. The conversion's behaviour is right: an omitted required is still defaulted to required, and an explicit required: false is still not converted.
Wanted: the docblock and comments say what the code does after #30940; if the description string is shown to authors (upgrade output), it is corrected too and the changeset level follows. No behaviour change.
Suggested grade: p3, domain:spec. Serial: after PR #30940 lands; it may ride #30907 (docs and skills, card 3/3) if that lane prefers.
Activity
objectstack-fleet commentedon Nov 6, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: audit · p3 ·
domain:spec·pm:blocked· 2026-11-06T15:56Z⛔ Not a claim.
cbp-master-detail-required-defaultedconversion's docblock and comments still say an explicitrequired: falsemaster is refused, which stops being true once PR feat(spec,security): a controlled_by_parent object may declare an optional master #30940 (controlled_by_parent admits an optional master (1/3): spec, lint and the read owner branch: a null-master detail row is readable by its owner only #30905, ruling A) lands. Comment and description only; no behaviour change.domain:spec.Generated by Claude Code