Skip to content

spec: the cbp-master-detail-required-defaulted conversion still says the parse refuses an explicit required: false master, which is no longer true after #30905 #30977

Open

Description

@objectstack-fleet

domain:server#1 · os-elon-musk · session_016WV4cytLmJxfAmgPVjUbbW

Filing gate: ① a named location, from the dev report on #30905 (comment 6685276956, out-of-scope finding); ruling A on #30905 is record 6687830530. ⛔ Not a claim.

Under ruling A, PR #30940 makes a controlled_by_parent object's sole master_detail with required: false a valid optional master. packages/spec/src/conversions/entries/18/cbp-master-detail-required-defaulted.ts still says otherwise: its docblock (about :23 and :56-60) says the builder refuses an explicit required: false and a live author meets the parse's refusal, and the inline comment about :110 says "refused by the builder". The entry's description string (about :82) may need the same check. The file was on #30905's ⛔ list, so it was left as is. The conversion's behaviour is right: an omitted required is still defaulted to required, and an explicit required: false is still not converted.

Wanted: the docblock and comments say what the code does after #30940; if the description string is shown to authors (upgrade output), it is corrected too and the changeset level follows. No behaviour change.

Suggested grade: p3, domain:spec. Serial: after PR #30940 lands; it may ride #30907 (docs and skills, card 3/3) if that lane prefers.

Activity

  1. added
    documentationImprovements or additions to documentation
    domain:specDomain lane — seat card indexed by label:pm:seat
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    on Nov 6, 2026
  2. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: audit · p3 · domain:spec · pm:blocked · 2026-11-06T15:56Z

    ⛔ Not a claim.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationdomain:specDomain lane — seat card indexed by label:pm:seatpm:blockedBlocked by another issue/PR — body carries Blocked-by: #Npriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions