Skip to content

ADR-0012 §6.1: the hosted push relay picks the generic notice line in the recipient's language, not "the device locale" (follow-up to #29920 Q4 C) #30670

Closed

Description

@objectstack-fleet

domain:server#2 · os-bill · session_01Utp6Cbvcmv8YWFhFJwzjKL

Filing gate: ③ a maintainer ruling that names this card: #29920 Q4 C (Ruling confirmed on the card, maintainer 「…其他同意」 2026-11-05T21:37Z), item 6 — "ADR-0012 §6.1's 'in the device locale' half-sentence is a separate docs follow-up card (docs/adr is out of this card)." ⛔ Not a claim. Suggested grade: p3.
Dedupe: ADR-0012 device locale push relay. Nearest: #29920 (the server half). New.

What is wrong

ADR-0012 §6.1 says the hosted relay's generic notice line is chosen "in the device locale". The ruling and the #29920 PR choose it by resolveRecipientLocale (sys_user.locale → deployment default), English when absent; push-relay.zod.ts's describe says "in the recipient's language".

Expected

One half-sentence in ADR-0012 §6.1 reworded to "in the recipient's language (sys_user.locale, then the deployment default)", with the ADR's amendment line and its scripts/adr-anchors/ anchor per the ADR conventions. docs/adr is Tier H: reviewers per the routing rule, the maintainer merges.

Reader: whoever carries ADR amendments (Tier H). Serial: after #29920's PR merges.

Activity

  1. added
    documentationImprovements or additions to documentation
    pm:queueReady for the PM dispatch loop
    domain:serverDomain lane — seat card indexed by label:pm:seat
    on Nov 5, 2026
  2. objectstack-fleet commented on Nov 5, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: audit · p3 kept · domain:server · 2026-11-05T22:55Z

    ⛔ Not a claim.


    Generated by Claude Code

  3. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#5 · os-elon-musk · session_016WV4cyvF7SP65frVFAYLv7

    Note for this card's carrier · 2026-11-06T01:22Z · ⛔ Not a claim.

    PR #30749 (#29920) amends ADR-0012's four "relay not served" readings, §6.1's "What main serves" bullet included, because that bullet anchored the export the PR retires. When you edit §6.1's privacy bullet here, also restore a tree pin on the "What main serves" heading (the replaced heading read "at 6a4737a, 2026-11-03"; name the commit the new reading was taken against): delta contract review 6674074177 on PR #30749, should-fix 1. Serial as before: after PR #30749 merges.

  4. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#5 · os-elon-musk · session_016WV4cyvF7SP65frVFAYLv7

    Claim: PM loop round 5 · 2026-11-06T05:18Z
    Session: session_016WV4cyvF7SP65frVFAYLv7
    Account: os-elon-musk (the seat's linked user as GET /user answers it; the card's assignee)
    Branch: the card thread's designated claude/project-thread-* branch; this claim is re-posted whole with it once the thread reports it, branched from main after PR #30749 merges
    Worktree: objectstack-issue-30670
    Domain: domain:server
    Seat: domain:server#5 (outside this seat's mod-4 share: it is the docs follow-up of this seat's #29920 / PR #30749, and the maintainer asked every seat to fill its five slots; the share seat may say so and the seat yields)
    File surface: docs/adr/0012-*.md §6.1 only: the "in the device locale" half-sentence reworded to "in the recipient's language (sys_user.locale, then the deployment default)", the ADR's amendment line, and a tree pin restored on the "What main serves" heading (delta review 6674074177 on PR #30749, should-fix 1, carried in note 6674101046); scripts/adr-anchors/** only if the ADR conventions require an anchor row for the edit. ⛔ code, ⛔ packages/**
    Container & model: S, mode:thread, model: default, effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: ADR-0012 §6.1 says the hosted relay picks the notice line in the device locale; the ruling and PR #30749 pick it by the recipient's sys_user.locale, then the deployment default | none | readers of ADR-0012
    Thread-read: 6674101046
    Premise: holds once PR #30749 (in the merge queue now) merges; the dev re-reads §6.1 on main after the merge first
    Serial constraints cleared: after PR #30749 merges (it edits ADR-0012 §6.1); docs/adr/** is Tier H, so landing needs a GOVERNED_APPROVERS approval or the maintainer's own merge

  5. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Nov 6, 2026
  6. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#5 · os-elon-musk · session_016WV4cyvF7SP65frVFAYLv7

    Claim: PM loop round 5 · 2026-11-06T05:21Z (re-posted whole with the branch, superseding the claim above)
    Session: session_016WV4cyvF7SP65frVFAYLv7
    Account: os-elon-musk (the seat's linked user as GET /user answers it; the card's assignee)
    Branch: claude/project-thread-r8swte (the card thread's designated branch, dev session session_016WV4cyJFQN5xeu4D3wmTU8), branched from main after PR #30749 merges
    Worktree: objectstack-issue-30670
    Domain: domain:server
    Seat: domain:server#5 (outside this seat's mod-4 share: it is the docs follow-up of this seat's #29920 / PR #30749, and the maintainer asked every seat to fill its five slots; the share seat may say so and the seat yields)
    File surface: docs/adr/0012-*.md §6.1 only: the "in the device locale" half-sentence reworded to "in the recipient's language (sys_user.locale, then the deployment default)", the ADR's amendment line, and a tree pin restored on the "What main serves" heading (delta review 6674074177 on PR #30749, should-fix 1, carried in note 6674101046); scripts/adr-anchors/** only if the ADR conventions require an anchor row for the edit. ⛔ code, ⛔ packages/**
    Container & model: S, mode:thread, model: default, effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: ADR-0012 §6.1 says the hosted relay picks the notice line in the device locale; the ruling and PR #30749 pick it by the recipient's sys_user.locale, then the deployment default | none | readers of ADR-0012
    Thread-read: 6674101046
    Premise: holds once PR #30749 (in the merge queue now) merges; the dev re-reads §6.1 on main after the merge first
    Serial constraints cleared: after PR #30749 merges (it edits ADR-0012 §6.1); docs/adr/** is Tier H, so landing needs a GOVERNED_APPROVERS approval or the maintainer's own merge

  7. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#5 · os-elon-musk · session_016WV4cyJFQN5xeu4D3wmTU8
    os-dev-report

    {
     "issue": 30670,
     "status": "done",
     "branch": "claude/project-thread-r8swte",
     "pr": "https://github.com/objectstack-ai/objectstack/pull/30834",
     "session": "session_016WV4cyJFQN5xeu4D3wmTU8",
     "premise_still_valid": true,
     "summary": "ADR-0012 §6.1's privacy bullet now says the relay's generic visible line is chosen in the recipient's language (sys_user.locale, then the deployment default), with an italic amendment note quoting 'in the device locale'. The 'What main serves' bullet names its tree again (objectstack-ai/objectstack at 97e42498, the PR #30749 merge; should-fix 1 of review 6674074177). The Status line gains one Amended clause for #30670. No adr-anchors row: anchors pin ADR ids in code files and this diff touches none. Branched from main 2038c56e after PR #30749 merged.",
     "tests": "none owed: ADR prose only (one file, +3/-3).",
     "gates": "local at d5b176c1: dispatch-gates --commands derived 21 families, all exit 0 (check:doc-formula-expressions exit 3 first, prerequisite; exit 0 after building @objectstack/formula + @objectstack/lint). Extra: pnpm check:cli-command-ids exit 0; check:adr-symbol-anchors is in the derived set, exit 0. --ran: 21 derived, 21 run, 0 NOT-MEASURED, 0 UNRUN. CI check-runs on PR #30834: in_progress at report time.",
     "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
     "mcp_calls": "4 — read only: issue_read get + get_comments (#30670), pull_request_read get (#30749), pull_request_read get (#30834)",
     "api_writes": "2 relay writes — fleet-write pr_create (PR #30834, label skip-changeset), post-stamped comment (this report). Plus git push of the branch.",
     "open_questions": [],
     "security_findings": "none",
     "out_of_scope_findings": []
    }
  8. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#5 · os-elon-musk · session_016WV4cyvF7SP65frVFAYLv7

    Landed · 2026-11-06T08:24Z · PR #30834

    Probe Reading
    PR #30834 merged, merge commit c50e0dfa, through the merge queue, enqueued and merged by os-zhuang (a GOVERNED_APPROVERS account; the human merge is the governed approval record). Tier H (docs/adr/**). Seat ACCEPT, contract review PASS 6678095806 and delta PASS 6678247372 all read head ad196da4
    #30670 closed by Fixes #30670

    Shipped: ADR-0012 §6.1's privacy bullet now names the recipient's language (sys_user.locale, then the deployment default, else English) for the relay's generic notice line, matching what PR #30749 serves (ruling Q4 C, item 6 of #29920). The Status line carries a dated Amended clause, and "What main serves" is pinned to 97e42498. Nothing carried.

    State change: pm:dispatched removed, assignee cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationdomain:serverDomain lane — seat card indexed by label:pm:seatpriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions