Skip to content

skills(objectstack-platform): plugin-development.md still lists a feature_flags settings manifest with ai_enabled / OS_FEATURE_FLAGS_*; PR #30272 removes that namespace #30275

Open

Description

@objectstack-fleet

domain:server#5 · os-bill · session_01Utp6CYVV6fcAQrNTDQRvPb

Filing gate ①: a shipped text that will say something wrong (skills/** ships to customer agents through npx skills add). The owed follow-up of PR #30272 (#30204), whose body carries Skills-docs: follow-up for it. No domain:* label is set: triage routes it.

Defect

skills/objectstack-platform/references/plugin-development.md:354–356 (read at origin/main 5fa9375e): "feature_flags settings manifest (@objectstack/service-settings) — org-tunable toggles like ai_enabled / beta_*, resolvable at runtime and env-overridable via OS_FEATURE_FLAGS_* (ADR-0007 settings cascade)."

PR #30272 removes the four feature_flags keys (none had a reader, ADR-0049 enforce-or-remove), the then-empty namespace, its Setup entry and the featureFlagsSettingsManifest export. After it merges, getManifest('feature_flags') throws UnknownNamespaceError, and OS_FEATURE_FLAGS_* env vars have no effect.

Business reason

A customer's AI agent reads this reference to build a plugin. Told there is an org-tunable feature_flags namespace, it writes ai_enabled checks against a namespace that no longer exists, or tells an administrator to set OS_FEATURE_FLAGS_AI_ENABLED, which does nothing.

Acceptance

  1. The bullet is removed, or replaced by the live answer: a plugin that needs an org toggle declares its own settings manifest; a capability a deployment advertises is PUBLIC_AUTH_FEATURES (the next bullet).
  2. The package's evals do not prompt for feature_flags (grep the evals; adjust any that do).
  3. Land after PR fix(service-settings)!: remove the Feature Flags page whose four toggles changed nothing #30272 merges, so the text matches main.

Reader who acts

domain:skills lane after triage. Tier H (governed surface skills/**): human merge.

Dedup

Searched issues: feature_flags plugin-development (1 hit: #30204 itself). No skills card covers this bullet.

Activity

  1. objectstack-fleet commented on Nov 5, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: first-touch audit · p3 kept · domain:skills · pm:queue kept · 2026-11-05T04:59Z

    ⛔ Not a claim.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions