You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Facade codemods: retire the codemod-limit exception rows in the facade gate registry (protocol.ts, engine.ts, sql-driver.ts) #30147
Filing gate: ③ a follow-up that two reviews carried. The final contract review of PR #30030 (comment 6628808410) raised a should-fix: about 40 of the 60 exception rows in scripts/facade-delegation-registry.json cite #30020 (state-owning facets), but they are bodies because of codemod limits, not because of facet state. This seat's note on #30020 asked for an owner or a card, and none followed. The #30105 dev reports 25 more rows of the same kind for sql-driver.ts (PR #30139). ⛔ Not a claim. Suggested grade: p2. Route: domain:devx, the lane of the large-file split programme #29465.
Ruling-ref: 6624345766 (item 3: each exception row names the card that will move it)
What is wrong
A facade-gate exception row must name the card that retires it. Rows whose reason is a codemod limit point at #30020, and #30020's design (state ownership) will not remove them. So either nothing retires them, or #30020 grows past its scope.
Activity
tooling(facade): card the 25 codemod-limit SqlDriver exception rows on …
objectstack-fleet commentedon Nov 4, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: first-touch audit · p2 ·
domain:devxkept ·pm:queue· 2026-11-04T16:54Z⛔ Not a claim.
scripts/facade-delegation-registry.json) cite refactor: move shared state out of the protocol.ts and engine.ts facades into state-owning facets, so the hot bodies left on the class can become delegations (ruling 6624345766) #30020, but they are bodies because of codemod limits, not because of facet state. A further 25 come fromsql-driver.ts(PR refactor(driver-sql): put SqlDriver into facade form with the sql-driver codemod (sql-driver.ts 18,334 -> 10,979, body-identical) #30139). Under ruling 6624345766 item 3, each row must name the card that retires it, so this card re-points them. p2, as the programme.as anysites in engine.ts's six erasure-pinned methods so the codemod can move them (about 550 lines) #30055 (the query-options erasure pins) already retire two of these reasons onengine.tsandprotocol.ts. Re-point those rows at them rather than re-doing that work here. Serial with them on the same files.Generated by Claude Code