Skip to content

refactor: sweep the #4918 as any sites in engine.ts's six erasure-pinned methods so the codemod can move them (about 550 lines) #30055

Open

Description

@objectstack-fleet

domain:server#6 · os-support-ai · session_01WGufzibcN9oHa8kDbTTnL5

Filing gate: the maintainer asked for this on PR #30012 at 2026-11-04T10:03Z (「我觉得文件还是太长,还有进一步的拆分优化空间吗」「可以后续立卡处理」「合并之后再继续」). The facades are merged: engine.ts as 237f513 (#30012) and protocol.ts as 48914fd (#29998). Estimates come from the #29986 / #29985 dev reports. ⛔ Not a claim. Triage sets the grade and the lane (devx or server).

Business reason: six ObjectQL methods (seedAutonumber, probeReferencingRows, resolveMasterDetailParent, resolveMasterDetailParents, inspectDanglingReferences, referenceExists; 555 lines) stay on the class as #30019 exceptions, because their #4918 query-options erasure is pinned by path (PATH_READER_PINS). Typing those sites removes the erasure, so the pins unpin and the bodies can move.
Reader who acts: packages/objectql owner.

What to do

Activity

  1. objectstack-fleet commented on Nov 4, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: first-touch audit · p2 · domain:server · pm:queue · 2026-11-04T11:56Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. objectstack-fleet commented on Nov 5, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#3 · os-bill · session_01Utp6CbPxYq1wQmUNWvMZkC

    Claim: PM loop round 2
    Session: session_01Utp6CbPxYq1wQmUNWvMZkC (seat) · dev = project card thread session_01Utp6CXX2qjqm2uXbJA8Jcv
    Account: os-bill
    Branch: claude/project-thread-wxc2gq
    Worktree: objectstack-issue-30055
    Domain: domain:server
    Seat: domain:server#3
    File surface: packages/objectql/src/** (engine.ts, the six methods' receiving modules, the erased sites), the PATH_READER_PINS registry and the #30019 no-body allow-list under scripts/**, tests, one changeset; a liveness ledger repoint only if check:liveness forces it — stop on breach; explain in the report.
    Container & model: M, mode:thread, model: default judgment tier (dispatch-gates --tier: no path-derived mandate; floor sonnet · default opus · ceiling fable), effort: high (M)
    Clause-②: no — internal typing and a codemod body move, public .d.ts unchanged; the dev measures
    Metadata-protocol: none
    Responsibility: domain:server seat 3; follow-up of #30053 (landed 11:16Z as 0c666c3), serial on engine.ts
    Thread-read: 6629969463
    Premise: holds
    Serial constraints cleared: #30053 merged (PR #30415, 0c666c3); #30370's PR #30416 (engine.ts stub) in the merge queue, branch after it lands or merge main

  3. objectstack-fleet commented on Nov 5, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#3 · os-bill · session_01Utp6CXX2qjqm2uXbJA8Jcv

    os-dev-report

    {
      "card": 30055,
      "pr": 30463,
      "draft": true,
      "branch": "claude/project-thread-wxc2gq",
      "head": "293b12ffec15abd89ec4f36b9fbf7b995e0ec481",
      "base_at_open": "f7afab86 (13 commits behind main c5800818 at open; none touch this diff's files)",
      "claim": 6656688704,
      "declarations": { "clause_2": "no", "metadata_protocol": "none", "changeset": "@objectstack/objectql patch" },
      "size": { "files": 9, "additions": 1479, "deletions": 609, "changed_lines": 2088, "cap": 3000 },
      "engine_ts_lines": { "main": 11771, "head": 11316 },
      "moved": ["seedAutonumber", "referenceExists", "resolveMasterDetailParent", "resolveMasterDetailParents", "inspectDanglingReferences", "probeReferencingRows"],
      "kept_assertions": ["seedAutonumber: keyset page query where slot named EngineQueryOptions['where']", "inspectDanglingReferences: port options handed over as EngineQueryOptions"],
      "retired": { "path_reader_pins": 6, "facade_delegation_exceptions": 6, "erasure_baseline_file": "packages/objectql/src/engine.ts (8 recorded, 6 measured, 0 now)" },
      "repointed": "durability-read-invention baseline: referenceExists -> engine-references-and-master-detail.ts",
      "proofs": {
        "codemod_verify": "--members --verify --base baf1a536^ exit 0 (6 moved, byte-for-byte undo of engine.ts and the three modules)",
        "dts": "core/index byte-identical; util .d.ts/.d.mts differ only by 211 moved private docblock lines each; docblock-stripped all six identical",
        "objectql_tests": "base 550 files / 10979 = head 550 / 10979",
        "typecheck": "exit 0",
        "ablation": "as any re-added on referenceExists in the references module: check:query-options-erasure exit 1 naming it; restored, hash verified"
      },
      "self_test": "codemod-split-engine 124 cases / 9 batteries (fourth-pass battery 18)",
      "gates": "dispatch-gates --commands 80 commands / 74 families, all exit 0; --ran 74/74, 0 NOT-MEASURED; check:liveness 0; check-facade-delegation-only 0 (62 exceptions)",
      "gate_reruns": ["check-plugin-teardown-shape --self-test: exit 3 until the pinned fixture commit was fetched", "check:dual-build-cjs-loads: exit 3 until pnpm build"],
      "assignees": "none (seat ruling)",
      "reviews_requested": "none",
      "security_findings": "none",
      "writes": { "api_writes": 2, "detail": "relay pr_create (read-back 10670 bytes identical) + this report", "branch_pushes": "yes, no force push" },
      "mcp_calls": { "total": 5, "writes": 0, "detail": "issue_read x4, pull_request_read x1" }
    }

    Report taken 2026-11-05T12:35Z.


    Generated by Claude Code

  4. objectstack-fleet commented on Nov 5, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#3 · os-bill · session_01Utp6CbPxYq1wQmUNWvMZkC

    ACCEPT → PR #30463 comment 6658708556 · 2026-11-05T13:04Z · landing held until p0 #30467 (main red) lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions