packages: customizations contributions follow-ups from #28722 — one stamp predicate for both kinds, and the schema docblock's over-claim about the pair's flows #28796
Description
domain:server#3 · os-project-manager · session_01FEkQ5kE5BrPUPNMMyv6oCH
Filing gate: ① the non-blocking should-fixes of the CONTRACT_REVIEW_TIER review 6561256710 on PR #28749, merged as 8196881e, Part of #28722. The review was re-confirmed twice: 6562066799 and 6562785424. Filed by domain:server seat 3. ⛔ Not a claim.
Wanted
- One stamp predicate. In
packages/runtime/src/domains/packages.ts,readBaseContributionsdecides "which package contributed this" withisCodeArtifactBodyon its flow branch but with a different reading on its field branch. Use the one predicate on both kinds, so a field and a flow carrying the same stamp are attributed alike. The two predicates diverge on no input in the tree today, so pin the shared reading with a test. - Docblock wording. The
contributionsdocblock inpackages/spec/src/api/package-lifecycle.zod.tssays the pair's items are "(listed above)" and never counted as contributions. That is too broad for the pair's flows. Say exactly what the answer lists and where.
⛔ No change to who is listed or to the answer's shape.
Dedupe
Read the open titles for contributions, readBaseContributions and customizations answer: only #28722 (open for its Wanted 3, waiting on #27928). New.
Reader who acts: domain:server (packages/runtime packages domain, packages/spec docblock).
Activity
objectstack-fleet commentedon Nov 1, 2026
domain:server#3 · os-project-manager · session_01FEkQ5kE5BrPUPNMMyv6oCH
Path: 能用的定制 | none | P③
Triage: p3 ·
domain:server·area:devpath· 2026-11-01T20:13Z⛔ Not a claim.
Clause-②: no,Metadata-protocol: none.objectstack-fleet commentedon Nov 1, 2026
domain:server#3 · os-project-manager · session_01FEkQ5kE5BrPUPNMMyv6oCH
Claim: PM loop round 1 · card thread · 2026-11-01T20:14Z
Session:
session_01FEkQ5kE5BrPUPNMMyv6oCH(the seat); the card thread issession_01FEkQ5ogKLgaK3fAZF4kmeFAccount:
os-project-manager(the seat's linked user; the card's assignee)Branch:
claude/project-thread-9q8qlz(the card thread's harness-pinned branch; it names no issue, so this claim is the identity record)Worktree: the card thread's own container checkout
Domain:
domain:serverSeat:
domain:server#3Ruling-ref: the maintainer, 2026-11-01T03:46Z: 「server 车道现在就是你负责，任务有一大堆啊，都可以派，包括 p3」, with 2026-10-26T10:29Z 「p1 p2 处理完了，就可以处理 p3」, and 2026-11-01T06:39Z 「server 队列还是很多任务，再开一个席位吧」. Seat 3 graded it p3 under 2026-11-01T12:11Z 「定级你可以自己决定」.
File surface:
packages/runtime/src/domains/packages.ts(readBaseContributions) and its tests, thecontributionsdocblock inpackages/spec/src/api/package-lifecycle.zod.ts(description text only) with its regenerated references, and changesets. ⛔ Noui/**; ⛔ no change to who is listed or to the answer shape.Container & model:
S,mode:thread,model: opus(--tiernames no path mandate: PM's call, default),effort: default (the coordinator sets effort only from the maintainer's words)Clause-②: no — expected: one predicate where two agree on every input in the tree, plus description text; nothing accepted or refused differently. The dev measures and declares. The spec path makes a
CONTRACT_REVIEW_TIERreview owed.Metadata-protocol: none (expected; the dev measures and declares)
Responsibility: the code is
packages/runtimepackages domain (readBaseContributions) and the spec docblock · the platform path isGET /packages/:id/customizations· reached by any installed base another package extendsThread-read: 6563285615
Premise: holds as filed (read by the #28749 review at
7edbf44b, re-confirmed onfb7fafd3); the dev re-reads onmainat8196881eor laterSerial constraints cleared: none: PR #28749 merged as
8196881e; the dev re-reads overlap at start and beforepr_create.Resume-from: none — the branch restarts from
origin/mainat8196881eor later (its PR #28749 is merged)State: →
pm:dispatched, assigned toos-project-manager, recorded by this claim. Order:pm-orders/server/order-28796.md(project folder).objectstack-fleet commentedon Nov 1, 2026
domain:server#3 · os-project-manager · session_01FEkQ5ogKLgaK3fAZF4kmeF
os-dev-report
{
"issue": 28796,
"status": "done",
"branch": "claude/project-thread-9q8qlz",
"pr": "#28807",
"session": "session_01FEkQ5ogKLgaK3fAZF4kmeF",
"premise_still_valid": true,
"summary": "Item 1: readBaseContributions now attributes both kinds through one predicate, codePackageOf(packageId, body): neither the base nor its pair, and isCodeArtifactBody accepts the stamp (not the sys_metadata sentinel, not a tenant-authored _provenance org body); the field branch passes the extend contributor's packageId and definition, the flow branch the flow's own _packageId and the flow. The flow branch's reading was taken for both: the only 'extend' registration in the tree is ObjectQL.registerApp under the manifest's package id, so the field listing is unchanged on every real input, while an id-only check could not serve flows, whose package is only a body stamp. Item 2: the TSDoc above GetPackageCustomizationsResponseSchema names exactly the two listed kinds and where the pair's items are instead (overrides, extensions, or no list); no .describe() changed. Branch restarted from origin/main 8196881 (the remote branch had been deleted on merge, so no force was needed).",
"tests": "pnpm --filter @objectstack/runtime exec vitest run src/domains/packages-customizations.test.ts: 18/18 at head. packages.ts at base 8196881: 1 failed | 17 passed (the new divergence pin). Ablations via scripts/ablation-replace.mjs, each restore proven (blob == HEAD 5488c8893cf3, git diff HEAD empty): field branch back to an id-only reading 1 red; flow branch to an id-only reading 2 red (divergence pin, environment-flow test). pnpm --filter @objectstack/runtime test: 508 files, 8229 passed, 19 skipped, exit 0. runtime typecheck and spec typecheck exit 0. Whole-repo pnpm build exit 0.",
"gates": "dispatch-gates --commands --repo objectstack-ai/objectstack: 81 commands, identical when re-derived after the loop. All 81 exit 0 on the first pass (after a whole-repo build). --ran verdict: 81 derived, 81 run, 0 NOT-MEASURED, exit 0. spec check:generated --fix: all 14 artifacts up to date. eslint --no-inline-config over the changed packages TS files exit 0. PR check-runs: in_progress at report time.",
"dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
"mcp_calls": "1 — issue_read get_comments #28796 (claim check); no write tools",
"api_writes": "2 — POST /repos/objectstack-ai/objectstack/dispatches for relay pr_create (#28807), and this os-dev-report comment via post-stamped; plus git push of the harness branch (not REST)",
"open_questions": [],
"out_of_scope_findings": [],
"deviations": "none. Declarations measured as the claim expected: Clause-②: no, Metadata-protocol: none; changeset patch on runtime and spec (the TSDoc ships in the spec .d.ts)."
}
Generated by Claude Code
objectstack-fleet commentedon Nov 1, 2026
domain:server#3 · os-project-manager · session_01FEkQ5kE5BrPUPNMMyv6oCH
ACCEPT → PR #28807 comment 6564134968 · head
6eeaf6a5· 2026-11-01T21:29Z · landing sent (ready + auto-merge;Clause-②: no, spec docblock path,CONTRACT_REVIEW_TIERPASS6563967996).Fixes #28796, so the merge closes this card.objectstack-fleet commentedon Nov 1, 2026
domain:server#3 · os-project-manager · session_01FEkQ5kE5BrPUPNMMyv6oCH
Landing record · #28796 · PR #28807
domain:serverseat 3 ·session_01FEkQ5kE5BrPUPNMMyv6oCH· 2026-11-01T21:50Zgit ls-remote origin 'refs/heads/gh-readonly-queue/main/pr-28807-*'git merge-base --is-ancestor 2081a5e5 origin/maingit grep -n "codePackageOf" origin/main -- packages/runtime/src/domains/packages.ts2081a5e5.GET /packages/:id/customizationsnow attributes a contributed field and a contributed flow by one stamp rule (codePackageOf). TheGetPackageCustomizationsResponseSchemadocblock now says where the pair's items are listed instead.CONTRACT_REVIEW_TIER): PASS6563967996on the landed head6eeaf6a5. Seat ACCEPT6564134968.Fixes #28796closed this card on merge. No out-of-scope findings.