Repository navigation
fix(portal): close gaps found in the v0.6 portal exit test - #94
Merged
Merged
Conversation
- Let category managers and buyer leads handle portal-submitted applications (edit sharing rule), require a return reason when sending an application back, notify the inviting manager on portal submission and the returning manager on resubmission - Hide internal navigation groups and internal-only actions from portal users behind a new srm_internal_access capability - Tell the supplier quality contact when a claim is raised on a SCAR (number only, no amount) - setup:local works under the invite-only membership policy and makes srmadmin an org admin; local demo doc covers the portal walkthrough - Design docs 02/03/04/05/07 updated; V6 records the local exit test Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ihL2fedQbjJWWSwaVb31Q
Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ihL2fedQbjJWWSwaVb31Q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 田騏 · project thread
Fixes found while running the v0.6 supplier-portal exit browser test locally (overview #75, exit conditions in 07 §6.2).
What the exit test found
处理准入申请onsrm_supplier_applicationfor category manager and buyer lead.srm_application_submitnotifies whoever raised the portal invitation.return_reason(required by validationreturn_reason_requiredwhen the status becomesreturned), visible to the portal so the supplier knows what to supplement.srm_application_resubmitfalls back to the person who returned the application (not the portal user who created it) when no reviewer is set.srm_internal_accessgranted bysrm_internal_baseandsrm_auditor; internal nav groups and internal actions (confirm legacy review, contract submit/activate, open portal, verify bank account, score submit, void, resolve appeal, reassign scorer) require it. "Submit appeal" stays ungated because internal staff relay appeals and the flow checks the roster itself.srm_scar_supplier_noticegets aclaimevent with new templatesrm_scar_claim_proposed(number only, no amount).pnpm setup:localfailed underOS_AUTH_MEMBERSHIP_POLICY=invite-only(required for the portal). The script now adds each account to the org and makessrmadminan org admin; local-demo.md documents the portal walkthrough.Docs
02 (
return_reason), 03 §3 step 4 / §8 step 6 / notify table, 04 §3.2, 05 §1 and §5, 07 §6.2 V6 (local exit test passed; hosted recheck still open), implementation/local-demo.md.Verification
pnpm validate,lint,typecheck,i18n:check,test(357 passed, 1 skipped),buildall pass locally. New tests: portal application handled by the inviting manager and returned only with a reason; claim notice to the supplier; internal capability only on internal positions and every nav group gated to internal or portal users. Isolation tests untouched.Generated by Claude Code