[objectstack-fleet]

Requested by Irene · project thread
Fixes #2366
Clause-②: no
Metadata-protocol: none

维护者速读

• 改了什么： 记录页只提供记录当前还能做的操作。报价单新增五个状态按钮（提交审核、标记为已提交、接受、拒绝、修订）；已接受、已拒绝、已过期的报价单不显示编辑、明细不显示新建，新建报价单不能直接是这三种状态（前端不提供选项，服务端也拒绝）；已拒绝的报价单在修订回草稿前冻结。工单新增“重新打开工单”，SLA 行为写进服务手册。已转化线索不显示编辑。营销活动的七个统计字段和成员的“已响应”“响应时间”改为只读。报价单、营销活动、活动成员、知识文章的状态选项声明 open/won/lost。
• 为什么改： QA: complete browser pass of HotCRM on @objectstack/* 18.2.0 — all 161 feature-inventory rows, Setup and Studio, in six tracks #2320 UX 走查的第 2 张卡（actions）：按钮出现了，保存时却被拒绝，或者状态变更只能靠编辑表单里的下拉框。
• 风险与回滚： 中低。谁能做什么没有变（共享、权限集、岗位都没动）；quote_status_progression 和 Show users the result of what they did, and say refusals in business words: enrolment counts, approval submission, stacked toasts, clone, double approval notices, quote and contract results, quote transitions, forecast validation, lead delete #2371 拥有的状态迁移拒绝块没动。行为变化：销售通过 API 以已接受/已拒绝/已过期创建报价单现在返回 400；已拒绝报价单在修订前只能改内部备注；用户写入统计字段会被丢弃。回滚即 revert 本 PR。
• 先看： src/revenue/actions/quote.actions.ts、src/revenue/objects/quote.hook.ts（新建拒绝与 Rejected 冻结）、src/revenue/objects/quote.object.ts（userActions 与选项 visibleWhen）、src/service/actions/case.actions.ts（reopen_case）。
• 两分钟验证： pnpm exec vitest run test/quote-settled-actions.test.ts test/quote-lifecycle-actions.test.ts test/case-reopen-action.test.ts test/campaign-metric-fields-readonly.test.ts，预期全部通过；或在控制台打开一张已提交的报价单，应看到“接受”“拒绝”按钮，接受后不再有“编辑”。
• 需要你做的： 第 6 行（锁定商机上的生成报价单）按 quote_generation leaves its quote behind when the deal is approval-locked: a rep's run fails RECORD_LOCKED at update_opportunity and the created quote stays #2015 的裁决保留未改，如仍要隐藏请裁决；其余无。

What changes

Each row of the card, with its verdict:

#	Row	Verdict	Where
1	Converted lead offers Edit	Fixed	crm_lead.userActions.edit.visibleWhen reads is_converted. The lock in lead.hook.ts is unchanged.
2	Settled quote offers Edit and a line-item New	Fixed	crm_quote.userActions.edit and crm_quote_line_item.userActions.create (the related list evaluates the host quote) hide both on Accepted, Rejected and Expired. Hiding Edit also removes the page's double-click inline editing (measured). quote_workflow's freeze now covers Rejected too, with status left writable so Revise is the way out.
3	A new quote may start Accepted/Rejected/Expired	Fixed	The three options carry visibleWhen: has(record.created_at): absent on the New form, present on every server insert (measured, seeds included). quote_workflow refuses a user's create at any of them, VALIDATION_FAILED / 400, with a userMessage. System writes (seed, import) still store them.
4	Hook-maintained campaign counters are editable	Fixed	actual_revenue and the six num_* fields on crm_campaign, and has_responded / response_date on crm_campaign_member, are readonly. campaign_metrics_refresh now runs runAs: 'system' like its three siblings, so its write is not stripped.
5	Agent sees Update Stage / New on a campaign's opportunities tab	Already fixed / by grant	Update Stage is already gone (#2338 item 4). New is the crm_user floor: /auth/me/permissions for service.agent lists crm_opportunity allowCreate: true, and a REST create answers 201. Changing that is a change to who may do what, out of scope.
6	Generate Quote while the deal is locked for approval	Not changed (premise)	#2015 ruled that quoting under approval drafts the quote and keeps the stage, pinned in test/flow-quote.test.ts. The console already greys Edit on the locked deal. Hiding Generate Quote there needs a ruling.
7	Edit inline for the agent	Already fixed / platform	The agent may edit their own opportunities (crm_user floor), and the platform's editInline default is on. Any remaining gating is objectstack#27355 row 6.
8	Reopen Case	Fixed	reopen_case: a declarative update to in_progress, offered on Resolved and Closed to callers who may edit cases (the grant Escalate and Close read). Listed in case_detail_page's header.
9	Quote lifecycle actions	Fixed	submit_quote_for_review, mark_quote_presented, accept_quote (with confirmText), reject_quote, revise_quote, each a declarative update of status alone, offered only on the statuses its move leaves from and only to callers who may edit quotes. → expired stays the sweep's. The allowed transitions are unchanged.
10	Option kind on quote, campaign-member and knowledge-article status	Fixed	Kinds declared. crm_campaign.status is included as the same defect class.

• Translations: the five quote actions and reopen_case in en, zh-CN, es-ES and ja-JP.
• In-app manual:
  • Quotes (crm_revenue_quotes): the buttons, how a quote starts, and settled quotes.
  • Cases (crm_service_cases): Reopen Case and what it does to the SLA.
  • Leads (crm_sales_leads): a converted lead has no Edit.
  • Campaigns (crm_marketing_campaigns): the numbers and the member's response fields are read-only.
  • Each page in en and zh.
• Docs site: content/docs/sales/quotes.* (en, zh-Hans, zh-Hant): a Rejected quote is revised with Revise and is frozen until then.
• Counts: README and docs/STATUS.md state 38 actions (pnpm validate).
• Changeset (minor).

Tests

• test/quote-settled-actions.test.ts (new, 25):
  • Both userActions predicates and the option predicates are evaluated on the platform's CEL engine, settled and open statuses, plus the first render.
  • A rep's REST create at each settled status is refused with the exact userMessage, and nothing is stored.
  • Controls: open statuses and a system seed of a settled quote still store.
  • A Rejected quote refuses field edits and a new line, still takes Internal Notes, and can be moved to Draft and revised there.
• test/quote-lifecycle-actions.test.ts (new, 18):
  • Every action's offered statuses are read off its visible and checked against quote_status_progression. Every declared move but → expired has an action.
  • The offer follows /auth/me/permissions: a rep is offered them; a marketing user and a service agent are offered none.
  • A rep walks a quote Draft → In Review → Presented → Accepted, and Presented → Rejected → Draft, through the action door. Another rep gets RECORD_NOT_FOUND / 404 and nothing moves.
• test/case-reopen-action.test.ts (new, 7):
  • Offered on Resolved and Closed to an agent only, not to a sales rep, and not before the record loads.
  • The run as the owning agent stores in_progress with is_closed false.
  • sla_due_date is kept, and is_sla_violated stays true.
• test/campaign-metric-fields-readonly.test.ts (new, 14):
  • Every metric field and both member fields are readonly, and all four refresh hooks run elevated.
  • A marketer's write of num_sent, num_responses and actual_revenue is dropped while the rest of the same write lands.
  • A marketer's has_responded / response_date is dropped.
  • Mark Responded still stamps both, and the campaign counts it.
  • The marketer's status move recomputes a knocked-off count.
• Updated:
  • test/status-option-kinds.test.ts: four new objects.
  • test/converted-lead-guard.test.ts: the Edit predicate.
  • test/refusal-labels.test.ts: the Rejected label and sentence.
  • test/refusal-envelope.test.ts: 35 → 36 call sites.
  • test/accepted-quote-frees-contact.test.ts: the born-without-contact case is now born Presented, since a user can no longer create a quote as Accepted.

Acceptance notes

• Browser (dev server, 18.2.0):
  • Quote buttons per status, and the Submit toast naming the quote.
  • An accepted quote with no Edit, no line New and no double-click editing.
  • The New form without the three settled options; the Edit form still lists them.
  • Campaign counters disabled on the edit form.
  • Reopen Case on a resolved case, with its toast.
  • The record path drawing Rejected and Expired as lost.
  • Not measured in the browser: row 1, because the dev seed has no converted lead. The predicate is pinned on the CEL engine, and userActions.edit behaved the same way on quotes.
• Line items on a settled quote keep their per-row Edit and Delete in the related list. A row action evaluates against the line, which does not carry its quote's status, and the server refuses those writes as before. Reported as a platform finding.
• Reopen and the close stamps: closed_date and resolution_time_hours keep the first close when a reopened case is closed again. This is pre-existing and also reachable through Edit, so it is not changed here and is in the report.
• zh-CN: a hook refusal carries no translation key on 18.2.0, so the new create refusal shows in English in zh-CN, as every hook refusal does (objectstack#26170).

Verification

pnpm verify at 9599f1f

pnpm verify (validate && typecheck && lint --strict && hygiene && hygiene:tokens && build && test)
  HotCRM v6.0.0 · Data: 20 Objects 375 Fields · UI: ... 38 Actions · Logic: 33 Flows
  build: 8 author-time warnings, all pre-existing approval-approvers-may-resolve-empty / hierarchy-security
 Test Files  246 passed (246)
      Tests  4703 passed | 1 skipped (4704)

b4e6e01 only adds a 30 s budget to two describes in test/campaign-metric-fields-readonly.test.ts (14/14 green, tsc --noEmit clean). CI runs coverage and e2e.

Ablations (on the committed tree; exact-anchor replace, anchor count 1 → 0, restored with git checkout, blob hash equal to HEAD after each)

A1 settled-create refusal disabled (false && …)      quote-settled-actions: 3 red (REST create accepted/rejected/expired)
A2 'rejected' dropped from the quote freeze           quote-settled-actions: 1 red (field edit on a Rejected quote)
A3 readonly dropped from num_sent                     campaign-metric-fields-readonly: 2 red (declaration, marketer write dropped)
A4 runAs dropped from campaign_metrics_refresh        campaign-metric-fields-readonly: 2 red (declaration, status move recomputes)
A5 current_user.can dropped from reopen_case.visible  case-reopen-action: 1 red (withheld from a sales rep)

🤖 Generated with Claude Code

https://claude.ai/code/session_01J8VVAmPx3rficEnw9LvZUQ

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
hotcrm	Ignored		Oct 29, 2026 3:52am UTC

[objectstack-fleet]

席位核对

Verdict: ACCEPT · repo:hotcrm seat 1 · huangyiirene · session session_01J8VVAnPkgK6CWrJa6t7Fk5 · 2026-10-29T03:54Z · head b4e6e01
Implemented-by: card thread session session_01J8VVAmPx3rficEnw9LvZUQ (report 6487444975 on #2366). Reviewed-by: the seat, against the 46-file diff and hotcrm origin/main 44d2d90.

• Shape:
  • Draft, base main, assignee huangyiirene. The body says Fixes #2366.
  • No governed path is touched.
  • The diff stays within claim 6486830702.
  • The status-transition block that Show users the result of what they did, and say refusals in business words: enrolment counts, approval submission, stacked toasts, clone, double approval notices, quote and contract results, quote transitions, forecast validation, lead delete #2371 owns is untouched; the state machine quote_status_progression is unchanged. The quote edits are the settled freeze (now including Rejected), its refusal sentences, and a new settled-create refusal.
  • The branch is cut from 44d2d90. git merge-tree against origin/main is clean.
• Rows, each measured first:
  • 1 A converted lead offers no Edit; userActions.edit reads is_converted. The lock is unchanged.
  • 2 A settled quote (Accepted, Rejected, Expired) offers no Edit, and its line items offer no New. The freeze now includes Rejected, with status still writable, so Revise can move the quote back to Draft. This is the card's target, which named Rejected as settled.
  • 3 The settled options are hidden on the New form. A user's create at a settled status is refused with VALIDATION_FAILED / 400 and a label userMessage. Seeds and system writes still pass. The option predicate is has(record.created_at), chosen by measurement: has(record.id) refuses every insert server-side.
  • 4 The campaign counters are readonly. campaign_metrics_refresh now runs as system, like its three siblings since Hooks that write or read across objects as the triggering person fail silently for reps, agents and web forms — 11 hook sites, one fix pattern (runAs), measured on the real engine by #2013 #2014, so its write is not stripped. Every read is keyed to the campaign.
  • 5 Already fixed: Update Stage has been gone since Browser pass #2320 on 18.2.0 — HotCRM-side defects (13 items: dashboards shown to personas with no access, a dead-end case close, campaign editors who cannot edit, a toolbar action that always fails, …) — list card, split per item at dispatch #2338 item 4. New opportunity is a crm_user floor grant, and grants are out of scope.
  • 6 Not changed. The premise is false: quote_generation leaves its quote behind when the deal is approval-locked: a rep's run fails RECORD_LOCKED at update_opportunity and the created quote stays #2015 ruled that quoting under approval drafts the quote, and flow-quote.test.ts pins that. The seat keeps quote_generation leaves its quote behind when the deal is approval-locked: a rep's run fails RECORD_LOCKED at update_opportunity and the created quote stays #2015 and does not take this to the maintainer.
  • 7 Already fixed. The remainder is objectstack#27355 row 6.
  • 8 reopen_case is a declarative update by the caller. The Service Manual states the SLA behaviour.
  • 9 Five quote lifecycle actions. Each one's visible is derived from the machine's own rows, and a test fails when the two disagree. Accept asks for confirmation first. Each success message names the quote.
  • 10 Option kind on quote, campaign member, knowledge article and campaign status.
• Tests:
  • pnpm verify is green at 9599f1f: 246 files, 4703 passed.
  • The new suites: quote-settled-actions 25, quote-lifecycle-actions 18, case-reopen-action 7, campaign-metric-fields-readonly 14.
  • Ablations A1–A5 each went red and were restored.
  • Browser check on the dev server: buttons per status, no Edit on an accepted quote, the New form without the settled options, disabled counters, Reopen Case.
• Gates: CI on b4e6e01: every run is success except Build and Test, which is still running.
• Out of scope: a reopened case that is closed again keeps its first closed_date and resolution_time_hours. crm_contract.status declares no kind. The seat files both as one follow-up card. Gating a related-list row action on the host record is a platform boundary, noted in the PR.
• Landing: non-governed. In this stroke the seat marks the PR ready and turns on auto-merge.

---

Generated by Claude Code