Repository navigation
Fix add-on failing to load on NVDA alpha: config.isAppX was removed - #63
Closed
serrebidev wants to merge 5 commits into
Closed
serrebidev wants to merge 5 commits into
serrebidev wants to merge 5 commits into
Conversation
The hourly check failed every run with no changes because `git commit` exits non-zero on an empty commit. Only commit and push when `git diff --cached` shows staged changes. Co-authored-by: Mark <mark@muse.ai>
NVDA alpha (2027.1 dev) removed config.isAppX along with Windows Store support. Accessing it raises AttributeError from config.__getattr__, so GlobalPlugin.__init__ fails and the add-on does not load: AttributeError: module 'config' has no attribute 'isAppX' Read it with getattr(..., False) so older NVDA keeps the Store check and newer NVDA treats the missing flag as "not a Store build". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Hi, |
Contributor
Author
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVDA alpha (2027.1 dev, tested on alpha-57943) removed
config.isAppXalong with Windows Store support. Reading it raisesAttributeErrorfromconfig.__getattr__, soGlobalPlugin.__init__fails and the add-on never loads:This reads the flag with
getattr(config, "isAppX", False)inaddon/globalPlugins/updateChannel.py. Older NVDA versions keep the Store check exactly as before; newer ones treat the missing flag as "not a Store build", which is what it means now that Store builds no longer exist.Verified: with this change installed, the add-on loads on alpha-57943 and the error is gone from the NVDA log.
🤖 Generated with Claude Code