[Lik Hern] iP by LikHern · Pull Request #488 · nus-cs2103-AY2223S1/ip

LikHern · 2022-08-27T11:40:27Z

DukePro

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you are Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String [] args) {
        Application.launch(MainApp.class, args);
    }
}

heyzec · 2022-08-31T14:15:41Z

+                break;
+            case BYE:
+                System.out.println("Bye. Hope to see you again soon!");
+                break UserInput;


Interesting use of Java labels!

yixiann

Generally a good job. Code is simple and easy to understand and follow. Naming of variables are also appropriate.

TJun-Jie

Great job! However, you can write more javadocs.

TJun-Jie · 2022-09-03T08:23:31Z

+        this.at = at;
+    }
+
+    @Override


Can write java docs

TJun-Jie · 2022-09-03T08:24:15Z

+        return isDone ? "X" : " ";
+    }
+
+    public void markAsDone() {


Can write java docs

TJun-Jie · 2022-09-03T08:24:37Z

+
+    @Override
+    public String toString() {
+        return String.format("[D]%s (by: %s)", super.toString(), by.format(DateTimeFormatter.ofPattern("MMM dd yyyy")));


Line too long, can break line in the middle

ssyap98 · 2022-09-04T14:49:50Z

+import java.time.format.DateTimeFormatter;
+
+public class Deadline extends Task {
+    protected LocalDate by;


Maybe you could name the variable as "deadLineTime" instead of "by"?

ssyap98 · 2022-09-04T14:51:14Z

@@ -0,0 +1,18 @@
+public class Event extends Task {
+    protected String at;


Just like the Deadline class, perhaps you can change the variable name from "at" to "eventTime"?

MinHeinA · 2022-09-04T15:19:12Z

Follows good OO practices, and good naming of variables. Related classes have not been placed in the same folder (package) and more JavaDocs could have been added.

clarence-chew

Nice work so far, good luck with your iP!

clarence-chew · 2022-09-05T09:57:53Z

+            case DEADLINE:
+                scanner.useDelimiter("/by");
+                String deadlineDescription = scanner.next().strip();
+                scanner.reset().skip("/by");
+                String deadlineBy = scanner.nextLine().strip();
+                Deadline deadlineTask = new Deadline(deadlineDescription, deadlineBy);
+                storage.add(deadlineTask);
+                System.out.println("Got it. I've added this task:\n" + deadlineTask
+                        + "\nNow you have " + storage.size() + " tasks in the list.");
+                break;
+            case EVENT:
+                scanner.useDelimiter("/at");
+                String eventDescription = scanner.next().strip();
+                scanner.reset().skip("/at");
+                String eventAt = scanner.nextLine().strip();
+                Event eventTask = new Event(eventDescription, eventAt);
+                storage.add(eventTask);
+                System.out.println("Got it. I've added this task:\n" + eventTask
+                        + "\nNow you have " + storage.size() + " tasks in the list.");
+                break;


Code seems to repeat the concept of finding some delimiter, perhaps this can be abstracted?

clarence-chew · 2022-09-05T10:00:07Z

+
+    protected Task(String description) {
+        this.description = description;
+        this.isDone = false;


Coding standard suggests avoiding unnecessary use of this with fields. (isDone here, in particular.)
https://se-education.org/guides/conventions/java/index.html#variables

…2223S1/ip

# Conflicts: # src/main/java/duke/ui/Ui.java

# Conflicts: # src/main/java/duke/task/Task.java

Include assertions to verify certain assumptions

Do refactor to improve code quality

damithc and others added 8 commits July 31, 2022 17:20

Add Gradle support

556af3f

$LAPTOP-3M0VCNEN\Lik Hern$

Add the ability to greet user, echo user input and exit program

f0c4e56

$LAPTOP-3M0VCNEN\Lik Hern$

Add the ability to store text and display to user when requested

4f8f316

$LAPTOP-3M0VCNEN\Lik Hern$

Add the ability to mark/unmark tasks as done/not done yet

f66f01b

$LAPTOP-3M0VCNEN\Lik Hern$

Add support for tracking three types of tasks: ToDos, Deadlines & Events

744d458

$LAPTOP-3M0VCNEN\Lik Hern$

Set up automated text UI testing

2da77c5

$LAPTOP-3M0VCNEN\Lik Hern$

Add the ability to handle certain exceptions

324e1b1

$LAPTOP-3M0VCNEN\Lik Hern$

Add support for deleting tasks from the list

90aead3

heyzec reviewed Aug 31, 2022

View reviewed changes

yixiann reviewed Sep 1, 2022

View reviewed changes

LAPTOP-3M0VCNEN\Lik Hern added 4 commits September 3, 2022 01:21

$LAPTOP-3M0VCNEN\Lik Hern$

Add the ability to save and load data from the hard disk

c56dde6

$LAPTOP-3M0VCNEN\Lik Hern$

Add the ability to identify certain date format and parse it correctly

89d2bfb

$LAPTOP-3M0VCNEN\Lik Hern$

Merge branch 'branch-Level-7'

4cd6136

$LAPTOP-3M0VCNEN\Lik Hern$

Merge branch 'branch-Level-8'

51cda61

TJun-Jie reviewed Sep 3, 2022

View reviewed changes

$LAPTOP-3M0VCNEN\Lik Hern$

Arrange the code to more closely follow OOP design

a200367

ssyap98 reviewed Sep 4, 2022

View reviewed changes

clarence-chew reviewed Sep 5, 2022

View reviewed changes

LAPTOP-3M0VCNEN\Lik Hern added 11 commits September 10, 2022 00:48

$LAPTOP-3M0VCNEN\Lik Hern$

Organize the classes into suitable java packages

634c9e6

$LAPTOP-3M0VCNEN\Lik Hern$

Merge branch 'add-gradle-support' of https://github.com/nus-cs2103-AY…

399a384

…2223S1/ip

$LAPTOP-3M0VCNEN\Lik Hern$

Add Gradle support to the project

f8ae081

$LAPTOP-3M0VCNEN\Lik Hern$

Add JUnit tests to test the behavior of the code

e1538fb

$LAPTOP-3M0VCNEN\Lik Hern$

Add JavaDoc comments to the code

4e9edd6

$LAPTOP-3M0VCNEN\Lik Hern$

Tweak the code to comply with a coding standard

abc6e72

$LAPTOP-3M0VCNEN\Lik Hern$

Add support for finding a task in task list by searching for a keyword

120db3d

$LAPTOP-3M0VCNEN\Lik Hern$

Merge branch 'branch-A-JavaDoc'

a97d88e

$LAPTOP-3M0VCNEN\Lik Hern$

Merge branch 'branch-A-CodingStandard'

ead284b

# Conflicts: # src/main/java/duke/ui/Ui.java

$LAPTOP-3M0VCNEN\Lik Hern$

Merge branch 'branch-Level-9'

ba7937c

# Conflicts: # src/main/java/duke/task/Task.java

$LAPTOP-3M0VCNEN\Lik Hern$

Add a GUI to Duke

050cef3

LAPTOP-3M0VCNEN\Lik Hern and others added 11 commits September 13, 2022 03:20

$LAPTOP-3M0VCNEN\Lik Hern$

Merge branch 'branch-Level-10'

d13c5bf

$LAPTOP-3M0VCNEN\Lik Hern$

Fixed minor problem related to GUI

2bb32f4

$LAPTOP-3M0VCNEN\Lik Hern$

Include assertions to verify certain assumptions

cbb027c

$LAPTOP-3M0VCNEN\Lik Hern$

Do refactor to improve code quality

e75560b

Merge pull request #2 from LikHern/branch-A-Assertions

cccbaca

Include assertions to verify certain assumptions

$LAPTOP-3M0VCNEN\Lik Hern$

Merge branch 'master' into branch-A-CodeQuality

0921acb

Merge pull request #3 from LikHern/branch-A-CodeQuality

859ae32

Do refactor to improve code quality

$LAPTOP-3M0VCNEN\Lik Hern$

Add support for archiving items

5e6b548

$LAPTOP-3M0VCNEN\Lik Hern$

Add a User Guide to the project

405f354

Update README.md

7658174

Update README.md

b49dcb9

Navigation Menu

Uh oh!

[Lik Hern] iP - #488

[Lik Hern] iP#488
LikHern wants to merge 35 commits into
nus-cs2103-AY2223S1:masterfrom
LikHern:master

LikHern commented Aug 27, 2022 •

edited

Loading

Uh oh!

heyzec Aug 31, 2022

Uh oh!

yixiann left a comment •

edited

Loading

Uh oh!

TJun-Jie left a comment

Uh oh!

TJun-Jie Sep 3, 2022

Uh oh!

TJun-Jie Sep 3, 2022

Uh oh!

TJun-Jie Sep 3, 2022

Uh oh!

ssyap98 Sep 4, 2022

Uh oh!

ssyap98 Sep 4, 2022

Uh oh!

MinHeinA commented Sep 4, 2022

Uh oh!

clarence-chew left a comment

Uh oh!

clarence-chew Sep 5, 2022

Uh oh!

clarence-chew Sep 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

		@@ -0,0 +1,18 @@
		public class Event extends Task {
		protected String at;

Uh oh!

Conversation

LikHern commented Aug 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DukePro

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yixiann left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TJun-Jie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MinHeinA commented Sep 4, 2022

Uh oh!

clarence-chew left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

LikHern commented Aug 27, 2022 •

edited

Loading

yixiann left a comment •

edited

Loading