Fix document reference elements being written in the wrong order - #180
Open
CasperBE wants to merge 1 commit into
Open
Fix document reference elements being written in the wrong order#180CasperBE wants to merge 1 commit into
CasperBE wants to merge 1 commit into
Conversation
UBL declares the document reference elements in an xsd:sequence, so the order they are written in is not cosmetic. Invoice, CreditNote and DebitNote share Invoice::xmlSerialize(), but each schema requires a different order, and the single hardcoded order matched none of them. On an Invoice, cac:ContractDocumentReference was written before cac:DespatchDocumentReference, and cac:OriginatorDocumentReference after cac:AdditionalDocumentReference. Any document combining a contract reference with a despatch, receipt or additional reference therefore failed schema validation. Also re-enables the contract reference in ContractDocumentReferenceTest, which built the object but never attached it to the invoice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UBL declares the document reference elements in an xsd:sequence, so the order they are written in is not cosmetic. Invoice, CreditNote and DebitNote share Invoice::xmlSerialize(), but each schema requires a different order, and the single hardcoded order matched none of them.
On an Invoice, cac:ContractDocumentReference was written before cac:DespatchDocumentReference, and cac:OriginatorDocumentReference after cac:AdditionalDocumentReference. Any document combining a contract reference with a despatch, receipt or additional reference therefore failed schema validation.
Also re-enables the contract reference in ContractDocumentReferenceTest, which built the object but never attached it to the invoice.